-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Multi module build #3704
[WIP] Multi module build #3704
Conversation
- FreeCite does not generate a non-used BibtexKeyGenerator anymore - Introduce ExporterFactoryFactory - Introduce SavePreferenceFactory
The fxml and css files should lie in the same folder as the view |
|
||
import java.nio.charset.Charset; | ||
|
||
public class SavePreferencesFactory { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can just move these methods to JabRefPreferences
.
732300e
to
df4ef0d
Compare
# Conflicts: # build.gradle
8a91c8b
to
0c96e14
Compare
# Conflicts: # org.jabref.gui/src/test/java/org/jabref/SearchQueryHighlightListenerTest.java # org.jabref.gui/src/test/java/org/jabref/gui/importer/EntryFromFileCreatorManagerTest.java # org.jabref.gui/src/test/java/org/jabref/gui/importer/EntryFromPDFCreatorTest.java # org.jabref.gui/src/test/java/org/jabref/preferences/LastFocusedTabPreferencesTest.java # org.jabref.logic/src/test/java/org/jabref/logic/xmp/XMPSchemaBibtexTest.java # org.jabref.model/src/test/java/org/jabref/model/strings/StringUtilTest.java # src/jmh/java/org/jabref/preferences/LastFocusedTabPreferencesTest.java # src/test/java/org/jabref/CodeStyleTests.java # src/test/java/org/jabref/logic/importer/DatabaseFileLookupTest.java # src/test/java/org/jabref/preferences/LastFocusedTabPreferencesTest.java
Solved via 9bfea57 Current state: Compiles fine on Windows, but on Linux:
Reproducible via
|
@@ -1,5 +1,6 @@ | |||
# no generated files in version control | |||
src/main/gen/ | |||
**/src/main/gen/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generated code like jabref.gui/src/main/gen/org/jabref/logic/importer/fileformat/mods/RoleTermDefinition.java is put under version control; is this desired?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should not happen. We have to remove that code.
I will double check.
# Conflicts: # org.jabref.gui/src/main/java/org/jabref/JabRefMain.java
This will be frozen until #3733 is merged. Reason: That PR also does huge refactorings. |
I close this PR as this is unfinished. I created #3913 as follow up. The small changes are filed as PRs #3907, #3908, #3909, #3910, #3911, #3912 The only thing not followed-up is the gradle multi-module-build (Co-Authored-By @stefan-kolb). I propose to leave it to @florian-beetz to investigate the gradle scripts and see whether they help him to get JabRef ready for Java9. |
This is a huge step towards #110 and prepares #3421 somehow.
This enables gradle multi module build.
The dependencies of "logic" were not as clean as I thought. I removed dependencies to GUI or moved packages back to gui (shared, remote).
We should get this in ASAP.
Open issues:
src/main/gen
should be removed from version control - generated code like jabref.gui/src/main/gen/org/jabref/logic/importer/fileformat/mods/RoleTermDefinition.java is put under version control; is this desired?Cannot load file GroupTree.fxml
jar
are not uploaded to CircleCI - are they stored somewhere else? http://builds.jabref.org/multi-module-build/:org.jabref.gui:junitPlatformTest
- this works locally though.[main] ERROR org.jabref.logic.l10n.Localization - Messages are not initialized before accessing All entries