migrate majority of tests to junit5 #3711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
please check if I didn't forgot one Test annotation
stefan-kolb
reviewed
Feb 8, 2018
| @@ -31,15 +31,14 @@ public void testExistenceOfIconImagesReferencedFromIconsProperties() throws IOEx | |||
| try (Reader reader = Files.newBufferedReader(Paths.get(iconsPropertiesPath))) { | |||
| properties.load(reader); | |||
| } | |||
| assertFalse("There must be loaded properties after loading " + iconsPropertiesPath, | |||
| properties.entrySet().isEmpty()); | |||
| assertFalse(properties.entrySet().isEmpty(), () -> "There must be loaded properties after loading " + iconsPropertiesPath); | |||
There was a problem hiding this comment.
Hm, not sure if I like these Supplier Lambdas...Are they really needed? Makes the methods look more complex and I doubt that the evaluation of the message really takes a long time. WDYT?
There was a problem hiding this comment.
In the beginning I did not see that I can pass the message as parameter without a supplier . The later tests are without. The supplier is only needed in the assertThroes
remove unnecessary supplier convert some more tests to junit5 fix imports
Mock externalFileTypes in importer test
Convert FormatterTest to junit5
convert architecture test to junit5
Siedlerchr
added
the
status: ready-for-review
tobiasdiez
approved these changes
Feb 11, 2018
|
I am still struggling with Install4J. Not sure, when I'll have one that fight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please check if I didn't forget one Test annotation