Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite web search pane in JavaFX #4203

Merged
merged 8 commits into from
Jul 24, 2018
Merged

Rewrite web search pane in JavaFX #4203

merged 8 commits into from
Jul 24, 2018

Conversation

tobiasdiez
Copy link
Member

@tobiasdiez tobiasdiez commented Jul 14, 2018 •
edited
Loading

Rewrite web search pane in JavaFX, with the aim to fix #4132.
image
(Still does not a win a prize of great ui design - e.g. the search button should be displayed as a real button; to be improved in further PRs)

Notable other changes:

  • Remove all remnants of the old fetcher infrastructure (yeah!)
  • Slightly improve command line output when using the -f (fetcher) option
  • Enable web search and groups pane by default
  • Fix bug where web search pane was not shown at start if it was active in last session
  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jul 14, 2018
Siedlerchr
Siedlerchr reviewed Jul 18, 2018
View reviewed changes
src/main/java/org/jabref/gui/JabRefFrame.java
@@ -254,7 +254,7 @@ private void init() {

// groupSidePane.getToggleCommand().setSelected(sidePaneManager.isComponentVisible(GroupSidePane.class));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be removed or rewritten?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point we should show the toggle state in the menu and I would hence leave this there as a reminder. Sadly, there is still a lot of such uncommented old in the maintable / frame / base panel classes...

Siedlerchr
Siedlerchr reviewed Jul 18, 2018
View reviewed changes
src/main/java/org/jabref/gui/importer/fetcher/WebSearchPane.java Outdated
search.setOnAction(event -> viewModel.search());

// Poor mans binding of default index
// (this logic should actually be in the view model but selected item property is readonly)
Copy link
Member

@Siedlerchr Siedlerchr Jul 18, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit// You need to use the valueProperty of the combobox, that is bidirectional.
The selected Item property is a bit confusing in the first moment,

https://docs.oracle.com/javase/8/javafx/api/javafx/scene/control/ComboBoxBase.html#valueProperty--

You only have to make sure that the Observable List is initialized before setting the properties.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hint. Works like a charm!

Siedlerchr
Siedlerchr requested changes Jul 19, 2018
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments

tobiasdiez and others added 2 commits July 22, 2018 12:05
@tobiasdiez
Use better binding and init default fetcher in view model as it shoul…
585dff6 
…d be
@Siedlerchr
remove obsolete l10n keys
3837462 
set search button to default so search can be executed by hitting enter
@Siedlerchr
Copy link
Member

I was so free to give your PR a try to see if the import inspection dialog is working again and made the search start on hitting enter.

Siedlerchr
Siedlerchr approved these changes Jul 23, 2018
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!

@Siedlerchr
Copy link
Member

I am going to merge this now as it finally makes the web search functioning again!

@Siedlerchr Siedlerchr merged commit 7b78458 into master Jul 24, 2018
@Siedlerchr Siedlerchr deleted the webSearchFX branch July 24, 2018 15:04
Siedlerchr added a commit that referenced this pull request Jul 25, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into fixattachfile
971b3c7 
* upstream/master:
  Fix isbn chimbori test (#4234)
  Rewrite web search pane in JavaFX (#4203)
Siedlerchr added a commit that referenced this pull request Jul 26, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into fixdragandrop
1d4db3d 
* upstream/master: (47 commits)
  Make attached files relative to the file directory (#4212)
  execute set visible in swing thread to avoid blocking
  Fix isbn chimbori test (#4234)
  Rewrite web search pane in JavaFX (#4203)
  Update dependencies (#4231)
  Update to latest release of richtextfx (#4213)
  Fix fetcher tests (#4216)
  single line text fields (#4138)
  Make it easier to rename and move files (#4200)
  Fix that swing dialogs are hidden behind main window (#4205)
  Fixed: #4166 add move & rename file (#4217)
  update gradle plugins and gradlen to 4.9
  Update dependencies
  Remove unnecessary look and feel migration (#4204)
  Revert threading fix since this sometimes lead to freezes...
  Update year
  Fix a few more threading exceptions
  Refactor
  Convert CiteSeerX fetcher to new infrastructure (#4185)
  Make global font size customizable (#4178)
  ...

# Conflicts:
#	src/main/java/org/jabref/gui/BasePanel.java
#	src/main/java/org/jabref/gui/JabRefFrame.java
#	src/main/java/org/jabref/gui/mergeentries/MergeEntries.java
#	src/main/resources/l10n/JabRef_en.properties
koppor added a commit that referenced this pull request Jan 2, 2020
@koppor
Squashed 'src/main/resources/csl-styles/' changes from 49a1841..b2fbe15
e19200b 
b2fbe15 APA 7th edition (#4419)
c236ade Create BFCN.csl (#4481)
25d40cd Update iso690-full-note-cs.csl (#4480)
5de3904 Update budownictwo-i-architektura-pl.csl (#4479)
9d9c1da Add files via upload (#4478)
96200b0 Create instituto-alberto-luiz-coimbra-de-pos-graduacao-e-pesquisa-de-… (#4476)
8aa9cb0 Update APA journal styles (#4475)
8549afa Update in-text citation for legal_case for BJPS (#4470)
71c9e4d Update surgical-neurology-international.csl (#4472)
a9dac17 Create FUNDING.yml
633e864 Create helsingin-yliopisto-teologinen-tiedekunta-teologian-tyyli.csl (#4303)
8797c01 Create romanian-iso-690-full-note-with-ibid-romanian.csl (#4465)
c1519e1 Create assosiation-of-firearms-and-toolmark-examiners.csl (#4468)
c974e30 Update ieee.csl (#4467)
a1b7386 Update stale.yml (#4466)
db549dd Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-ser… (#4462)
2822437 Update .travis.yml (#4463)
3d72c62 WIP: Adding deprecation notice to DIN1505-2 saying it has been superseded by ISO 690 (#4454)
1928c2b Fix links after KI update
fad65b7 Turn Kidney International into AMA dependent
6357af5 Update association-for-computing-machinery.csl (#4459)
eab02ea Create berlin-school-of-economics-and-law-international-marketing-man… (#3774)
a3e3d97 One more metadata fix
e7d5071 Some Sheldon metadata fixes
3ad4260 Create jurnal-sains-farmasi-dan-klinis.csl (#4455)
46370dc Add "AIMS Press" journals (#4458)
57fca07 Update association-for-computing-machinery.csl (#4456)
6fa90ed Add "Muséum national d'Histoire naturelle" journal styles (#4457)
7faf0b0 Bundle update
e3c1f85 Create cryptogamie, bryologie (#4350)
525bba5 Create iso690-full-note-cs.csl (#4414)
932fad5 Create iso690-author-date-de.csl (#4344)
ab23108 Create mbts-fullnote-bibliography.csl (#4363)
c163008 Create associacao-brasileira-de-normas-tecnicas-ibict-full.csl (#4202)
5586bbc Create associacao-brasileira-de-normas-tecnicas-ibict-initials.csl (#4203)
483efcb Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-service-engineering.csl (#4442)
92f437d Create independent style for molecular-nutrition-and-food-research.csl… (#4342)
0d7f481 Update taylor-and-francis-council-of-science-editors-author-date.csl (#4385)
2b2786b Create ritid-timarit-hugvisindastofnunnar.csl (#4315)
9534999 Create jsbm.csl (#4371)
b390657 Changed term on access macro, added rules for bill (#4407)
95c24f9 Create ecausp-abnt.csl (#4420)
66ca962 Reindent/reorder
91fefee Create materials-express.csl (#4445)
ea5d50b Create institut-catholique-de-paris.csl (#4450)
a4c07e2 Create institut-catholique-de-paris.csl (#4374)
8a17ae0 Update canadian-geotechnical-journal.csl (#4447)
7165db0 Update ens-de-lyon-centre-d-ingenierie-documentaire.csl (#4448)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: b2fbe15
github-actions bot pushed a commit that referenced this pull request Jan 2, 2020
Squashed 'src/main/resources/csl-styles/' changes from 49a1841..b2fbe15
c63d290 
b2fbe15 APA 7th edition (#4419)
c236ade Create BFCN.csl (#4481)
25d40cd Update iso690-full-note-cs.csl (#4480)
5de3904 Update budownictwo-i-architektura-pl.csl (#4479)
9d9c1da Add files via upload (#4478)
96200b0 Create instituto-alberto-luiz-coimbra-de-pos-graduacao-e-pesquisa-de-… (#4476)
8aa9cb0 Update APA journal styles (#4475)
8549afa Update in-text citation for legal_case for BJPS (#4470)
71c9e4d Update surgical-neurology-international.csl (#4472)
a9dac17 Create FUNDING.yml
633e864 Create helsingin-yliopisto-teologinen-tiedekunta-teologian-tyyli.csl (#4303)
8797c01 Create romanian-iso-690-full-note-with-ibid-romanian.csl (#4465)
c1519e1 Create assosiation-of-firearms-and-toolmark-examiners.csl (#4468)
c974e30 Update ieee.csl (#4467)
a1b7386 Update stale.yml (#4466)
db549dd Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-ser… (#4462)
2822437 Update .travis.yml (#4463)
3d72c62 WIP: Adding deprecation notice to DIN1505-2 saying it has been superseded by ISO 690 (#4454)
1928c2b Fix links after KI update
fad65b7 Turn Kidney International into AMA dependent
6357af5 Update association-for-computing-machinery.csl (#4459)
eab02ea Create berlin-school-of-economics-and-law-international-marketing-man… (#3774)
a3e3d97 One more metadata fix
e7d5071 Some Sheldon metadata fixes
3ad4260 Create jurnal-sains-farmasi-dan-klinis.csl (#4455)
46370dc Add "AIMS Press" journals (#4458)
57fca07 Update association-for-computing-machinery.csl (#4456)
6fa90ed Add "Muséum national d'Histoire naturelle" journal styles (#4457)
7faf0b0 Bundle update
e3c1f85 Create cryptogamie, bryologie (#4350)
525bba5 Create iso690-full-note-cs.csl (#4414)
932fad5 Create iso690-author-date-de.csl (#4344)
ab23108 Create mbts-fullnote-bibliography.csl (#4363)
c163008 Create associacao-brasileira-de-normas-tecnicas-ibict-full.csl (#4202)
5586bbc Create associacao-brasileira-de-normas-tecnicas-ibict-initials.csl (#4203)
483efcb Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-service-engineering.csl (#4442)
92f437d Create independent style for molecular-nutrition-and-food-research.csl… (#4342)
0d7f481 Update taylor-and-francis-council-of-science-editors-author-date.csl (#4385)
2b2786b Create ritid-timarit-hugvisindastofnunnar.csl (#4315)
9534999 Create jsbm.csl (#4371)
b390657 Changed term on access macro, added rules for bill (#4407)
95c24f9 Create ecausp-abnt.csl (#4420)
66ca962 Reindent/reorder
91fefee Create materials-express.csl (#4445)
ea5d50b Create institut-catholique-de-paris.csl (#4450)
a4c07e2 Create institut-catholique-de-paris.csl (#4374)
8a17ae0 Update canadian-geotechnical-journal.csl (#4447)
7165db0 Update ens-de-lyon-centre-d-ingenierie-documentaire.csl (#4448)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: b2fbe15
github-actions bot pushed a commit to calixtus/jabref that referenced this pull request Jan 10, 2020
Squashed 'src/main/resources/csl-styles/' changes from 49a1841..bfffaed
5227b6f 
bfffaed APA: Fix sort order for in-text citations (JabRef#4495)
c48d08b Add "Blood Cancer Discovery" for AACR (JabRef#4492)
f628cb2 Medizinische Fakultät Mannheim - Numerisch (JabRef#4490)
77876a4 Improve legal cites for british-journal-of-political-science (JabRef#4488)
3c0c4ee Create apa-with-abstract.csl (JabRef#4487)
a26fa95 Update afte-journal.csl (JabRef#4489)
a7bf678 Create agriculturae-conspectus-scientificus.csl (JabRef#4491)
bb01625 Make ET&C dependent of CSE (JabRef#4483)
b4418ef Create ahmad-ibrahim-kulliyyah-of-laws-international-islamic-universi… (JabRef#4482)
22872d2 APA: Use "et al." in Dutch (JabRef#4484)
5f6c080 Update weed-research.csl (JabRef#4485)
b2fbe15 APA 7th edition (JabRef#4419)
c236ade Create BFCN.csl (JabRef#4481)
25d40cd Update iso690-full-note-cs.csl (JabRef#4480)
5de3904 Update budownictwo-i-architektura-pl.csl (JabRef#4479)
9d9c1da Add files via upload (JabRef#4478)
96200b0 Create instituto-alberto-luiz-coimbra-de-pos-graduacao-e-pesquisa-de-… (JabRef#4476)
8aa9cb0 Update APA journal styles (JabRef#4475)
8549afa Update in-text citation for legal_case for BJPS (JabRef#4470)
71c9e4d Update surgical-neurology-international.csl (JabRef#4472)
a9dac17 Create FUNDING.yml
633e864 Create helsingin-yliopisto-teologinen-tiedekunta-teologian-tyyli.csl (JabRef#4303)
8797c01 Create romanian-iso-690-full-note-with-ibid-romanian.csl (JabRef#4465)
c1519e1 Create assosiation-of-firearms-and-toolmark-examiners.csl (JabRef#4468)
c974e30 Update ieee.csl (JabRef#4467)
a1b7386 Update stale.yml (JabRef#4466)
db549dd Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-ser… (JabRef#4462)
2822437 Update .travis.yml (JabRef#4463)
3d72c62 WIP: Adding deprecation notice to DIN1505-2 saying it has been superseded by ISO 690 (JabRef#4454)
1928c2b Fix links after KI update
fad65b7 Turn Kidney International into AMA dependent
6357af5 Update association-for-computing-machinery.csl (JabRef#4459)
eab02ea Create berlin-school-of-economics-and-law-international-marketing-man… (JabRef#3774)
a3e3d97 One more metadata fix
e7d5071 Some Sheldon metadata fixes
3ad4260 Create jurnal-sains-farmasi-dan-klinis.csl (JabRef#4455)
46370dc Add "AIMS Press" journals (JabRef#4458)
57fca07 Update association-for-computing-machinery.csl (JabRef#4456)
6fa90ed Add "Muséum national d'Histoire naturelle" journal styles (JabRef#4457)
7faf0b0 Bundle update
e3c1f85 Create cryptogamie, bryologie (JabRef#4350)
525bba5 Create iso690-full-note-cs.csl (JabRef#4414)
932fad5 Create iso690-author-date-de.csl (JabRef#4344)
ab23108 Create mbts-fullnote-bibliography.csl (JabRef#4363)
c163008 Create associacao-brasileira-de-normas-tecnicas-ibict-full.csl (JabRef#4202)
5586bbc Create associacao-brasileira-de-normas-tecnicas-ibict-initials.csl (JabRef#4203)
483efcb Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-service-engineering.csl (JabRef#4442)
92f437d Create independent style for molecular-nutrition-and-food-research.csl… (JabRef#4342)
0d7f481 Update taylor-and-francis-council-of-science-editors-author-date.csl (JabRef#4385)
2b2786b Create ritid-timarit-hugvisindastofnunnar.csl (JabRef#4315)
9534999 Create jsbm.csl (JabRef#4371)
b390657 Changed term on access macro, added rules for bill (JabRef#4407)
95c24f9 Create ecausp-abnt.csl (JabRef#4420)
66ca962 Reindent/reorder
91fefee Create materials-express.csl (JabRef#4445)
ea5d50b Create institut-catholique-de-paris.csl (JabRef#4450)
a4c07e2 Create institut-catholique-de-paris.csl (JabRef#4374)
8a17ae0 Update canadian-geotechnical-journal.csl (JabRef#4447)
7165db0 Update ens-de-lyon-centre-d-ingenierie-documentaire.csl (JabRef#4448)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: bfffaed
github-actions bot pushed a commit to NikodemKch/jabref-1 that referenced this pull request Feb 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 49a1841..e2416fa
351911f 
e2416fa Update clinical-and-experimental-optometry.csl (JabRef#4538)
e71363e Create geriatrie-et-psychologie-neuropsychiatrie-du-vieillissement.csl (JabRef#4543)
cdd973e APA: Add "personal communication" localization (JabRef#4539)
77bdb6f Create eksploatacja-i-niezawodnosc (JabRef#4531)
7858966 Ready: Update psychological-medicine.csl (JabRef#4536)
264141a Create south-african-actuarial-journal.csl (JabRef#4534)
1fde301 Create pakistan-journal-of-agricultural-sciences.csl (JabRef#4535)
3020eb3 Update hochschule-fur-soziale-arbeit-fhnw.csl (JabRef#4533)
57c8122 Update john-benjamins-publishing-company-linguistik-aktuell-linguistics-today.csl (JabRef#4530)
17c178f Update zeitschrift-fur-internationale-beziehungen.csl (JabRef#4527)
14cf589 Update john-benjamins-publishing-company-linguistik-aktuell-linguistics-today.csl (JabRef#4528)
ca60d6e Update john-benjamins-publishing-company-linguistik-aktuell-linguistics-today.csl (JabRef#4524)
74c5ae9 Update groupe-danthropologie-et-darcheologie-funeraire.csl (JabRef#4526)
999e124 Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (JabRef#4521)
caabe36 Fix psychiatric services
f50e6f0 Add files via upload (JabRef#4519)
c728658 Create harvard-lancaster-university.csl (JabRef#4520)
11e9ac9 Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4511)
101b81c Update agriculturae-conspectus-scientificus.csl (JabRef#4510)
615377e Create international-journal-of-population-data-science.csl (JabRef#4517)
fe7cb69 Update university-of-york-apa.csl
f0c7374 Fix AGLC Subsequents
6a8ec90 More Uni Gottingen fixes
9c0f5c6 Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (JabRef#4460)
22ef83d Update Universitatsmedizin Gottingen
d2f90c9 Create drying-technology.csl (JabRef#4515)
01e339b Create terrorism-and-political-violence.csl (JabRef#4514)
6414c15 Create international-journal-of-hyperthermia.csl (JabRef#4513)
f80b38c Create Sciences Po - Ecole doctorale (note, French) (JabRef#4486)
6a22929 Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4508)
19c89f5 Create citation-compass-apa-note.csl (JabRef#4500)
fe72590 Chicago fixes & add no-ibid variant (JabRef#4503)
d602477 Update agriculturae-conspectus-scientificus.csl (JabRef#4505)
8a8911b Create mediterranean-journal-of-chemistry.csl (JabRef#4506)
ce77b28 Create conservation-and-society.csl (JabRef#4507)
25a5092 Add IMS journals (JabRef#4496)
a39430e Create rmit-university-harvard.csl (JabRef#4504)
830aa7b Update john-benjamins-publishing-company-collective-volumes.csl (JabRef#4444)
43e9216 Create PHBern IVP (JabRef#4427)
a052fd6 Create Publications du Groupe d'anthropologie et d'archéologie funéra… (JabRef#4499)
a7e12e1 Further improve legal cites for BJPS (JabRef#4497)
744a507 Update agriculturae-conspectus-scientificus.csl (JabRef#4498)
bfffaed APA: Fix sort order for in-text citations (JabRef#4495)
c48d08b Add "Blood Cancer Discovery" for AACR (JabRef#4492)
f628cb2 Medizinische Fakultät Mannheim - Numerisch (JabRef#4490)
77876a4 Improve legal cites for british-journal-of-political-science (JabRef#4488)
3c0c4ee Create apa-with-abstract.csl (JabRef#4487)
a26fa95 Update afte-journal.csl (JabRef#4489)
a7bf678 Create agriculturae-conspectus-scientificus.csl (JabRef#4491)
bb01625 Make ET&C dependent of CSE (JabRef#4483)
b4418ef Create ahmad-ibrahim-kulliyyah-of-laws-international-islamic-universi… (JabRef#4482)
22872d2 APA: Use "et al." in Dutch (JabRef#4484)
5f6c080 Update weed-research.csl (JabRef#4485)
b2fbe15 APA 7th edition (JabRef#4419)
c236ade Create BFCN.csl (JabRef#4481)
25d40cd Update iso690-full-note-cs.csl (JabRef#4480)
5de3904 Update budownictwo-i-architektura-pl.csl (JabRef#4479)
9d9c1da Add files via upload (JabRef#4478)
96200b0 Create instituto-alberto-luiz-coimbra-de-pos-graduacao-e-pesquisa-de-… (JabRef#4476)
8aa9cb0 Update APA journal styles (JabRef#4475)
8549afa Update in-text citation for legal_case for BJPS (JabRef#4470)
71c9e4d Update surgical-neurology-international.csl (JabRef#4472)
a9dac17 Create FUNDING.yml
633e864 Create helsingin-yliopisto-teologinen-tiedekunta-teologian-tyyli.csl (JabRef#4303)
8797c01 Create romanian-iso-690-full-note-with-ibid-romanian.csl (JabRef#4465)
c1519e1 Create assosiation-of-firearms-and-toolmark-examiners.csl (JabRef#4468)
c974e30 Update ieee.csl (JabRef#4467)
a1b7386 Update stale.yml (JabRef#4466)
db549dd Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-ser… (JabRef#4462)
2822437 Update .travis.yml (JabRef#4463)
3d72c62 WIP: Adding deprecation notice to DIN1505-2 saying it has been superseded by ISO 690 (JabRef#4454)
1928c2b Fix links after KI update
fad65b7 Turn Kidney International into AMA dependent
6357af5 Update association-for-computing-machinery.csl (JabRef#4459)
eab02ea Create berlin-school-of-economics-and-law-international-marketing-man… (JabRef#3774)
a3e3d97 One more metadata fix
e7d5071 Some Sheldon metadata fixes
3ad4260 Create jurnal-sains-farmasi-dan-klinis.csl (JabRef#4455)
46370dc Add "AIMS Press" journals (JabRef#4458)
57fca07 Update association-for-computing-machinery.csl (JabRef#4456)
6fa90ed Add "Muséum national d'Histoire naturelle" journal styles (JabRef#4457)
7faf0b0 Bundle update
e3c1f85 Create cryptogamie, bryologie (JabRef#4350)
525bba5 Create iso690-full-note-cs.csl (JabRef#4414)
932fad5 Create iso690-author-date-de.csl (JabRef#4344)
ab23108 Create mbts-fullnote-bibliography.csl (JabRef#4363)
c163008 Create associacao-brasileira-de-normas-tecnicas-ibict-full.csl (JabRef#4202)
5586bbc Create associacao-brasileira-de-normas-tecnicas-ibict-initials.csl (JabRef#4203)
483efcb Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-service-engineering.csl (JabRef#4442)
92f437d Create independent style for molecular-nutrition-and-food-research.csl… (JabRef#4342)
0d7f481 Update taylor-and-francis-council-of-science-editors-author-date.csl (JabRef#4385)
2b2786b Create ritid-timarit-hugvisindastofnunnar.csl (JabRef#4315)
9534999 Create jsbm.csl (JabRef#4371)
b390657 Changed term on access macro, added rules for bill (JabRef#4407)
95c24f9 Create ecausp-abnt.csl (JabRef#4420)
66ca962 Reindent/reorder
91fefee Create materials-express.csl (JabRef#4445)
ea5d50b Create institut-catholique-de-paris.csl (JabRef#4450)
a4c07e2 Create institut-catholique-de-paris.csl (JabRef#4374)
8a17ae0 Update canadian-geotechnical-journal.csl (JabRef#4447)
7165db0 Update ens-de-lyon-centre-d-ingenierie-documentaire.csl (JabRef#4448)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: e2416fa
github-actions bot pushed a commit to ddunig2/jabref that referenced this pull request Feb 6, 2020
Squashed 'src/main/resources/csl-styles/' changes from 49a1841..e106215
60b2b9b 
e106215 Create annales-de-demographie-historique.csl (JabRef#4512)
4dd974e Create lauterbornia.csl (JabRef#4525)
e5277ae Update sciences-po-ecole-doctorale-note-french.csl (JabRef#4551)
f9cfe40 Add new IOP dependents (JabRef#4549)
daff985 Create brazilian-journal-of-veterinary-research-and-animal-science.csl (JabRef#4544)
10c6fa8 Update ens-de-lyon-centre-d-ingenierie-documentaire.csl (JabRef#4545)
c531528 create mcgill9-en.csl, Canadian McGill legal style (JabRef#4532)
e2416fa Update clinical-and-experimental-optometry.csl (JabRef#4538)
e71363e Create geriatrie-et-psychologie-neuropsychiatrie-du-vieillissement.csl (JabRef#4543)
cdd973e APA: Add "personal communication" localization (JabRef#4539)
77bdb6f Create eksploatacja-i-niezawodnosc (JabRef#4531)
7858966 Ready: Update psychological-medicine.csl (JabRef#4536)
264141a Create south-african-actuarial-journal.csl (JabRef#4534)
1fde301 Create pakistan-journal-of-agricultural-sciences.csl (JabRef#4535)
3020eb3 Update hochschule-fur-soziale-arbeit-fhnw.csl (JabRef#4533)
57c8122 Update john-benjamins-publishing-company-linguistik-aktuell-linguistics-today.csl (JabRef#4530)
17c178f Update zeitschrift-fur-internationale-beziehungen.csl (JabRef#4527)
14cf589 Update john-benjamins-publishing-company-linguistik-aktuell-linguistics-today.csl (JabRef#4528)
ca60d6e Update john-benjamins-publishing-company-linguistik-aktuell-linguistics-today.csl (JabRef#4524)
74c5ae9 Update groupe-danthropologie-et-darcheologie-funeraire.csl (JabRef#4526)
999e124 Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (JabRef#4521)
caabe36 Fix psychiatric services
f50e6f0 Add files via upload (JabRef#4519)
c728658 Create harvard-lancaster-university.csl (JabRef#4520)
11e9ac9 Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4511)
101b81c Update agriculturae-conspectus-scientificus.csl (JabRef#4510)
615377e Create international-journal-of-population-data-science.csl (JabRef#4517)
fe7cb69 Update university-of-york-apa.csl
f0c7374 Fix AGLC Subsequents
6a8ec90 More Uni Gottingen fixes
9c0f5c6 Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (JabRef#4460)
22ef83d Update Universitatsmedizin Gottingen
d2f90c9 Create drying-technology.csl (JabRef#4515)
01e339b Create terrorism-and-political-violence.csl (JabRef#4514)
6414c15 Create international-journal-of-hyperthermia.csl (JabRef#4513)
f80b38c Create Sciences Po - Ecole doctorale (note, French) (JabRef#4486)
6a22929 Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4508)
19c89f5 Create citation-compass-apa-note.csl (JabRef#4500)
fe72590 Chicago fixes & add no-ibid variant (JabRef#4503)
d602477 Update agriculturae-conspectus-scientificus.csl (JabRef#4505)
8a8911b Create mediterranean-journal-of-chemistry.csl (JabRef#4506)
ce77b28 Create conservation-and-society.csl (JabRef#4507)
25a5092 Add IMS journals (JabRef#4496)
a39430e Create rmit-university-harvard.csl (JabRef#4504)
830aa7b Update john-benjamins-publishing-company-collective-volumes.csl (JabRef#4444)
43e9216 Create PHBern IVP (JabRef#4427)
a052fd6 Create Publications du Groupe d'anthropologie et d'archéologie funéra… (JabRef#4499)
a7e12e1 Further improve legal cites for BJPS (JabRef#4497)
744a507 Update agriculturae-conspectus-scientificus.csl (JabRef#4498)
bfffaed APA: Fix sort order for in-text citations (JabRef#4495)
c48d08b Add "Blood Cancer Discovery" for AACR (JabRef#4492)
f628cb2 Medizinische Fakultät Mannheim - Numerisch (JabRef#4490)
77876a4 Improve legal cites for british-journal-of-political-science (JabRef#4488)
3c0c4ee Create apa-with-abstract.csl (JabRef#4487)
a26fa95 Update afte-journal.csl (JabRef#4489)
a7bf678 Create agriculturae-conspectus-scientificus.csl (JabRef#4491)
bb01625 Make ET&C dependent of CSE (JabRef#4483)
b4418ef Create ahmad-ibrahim-kulliyyah-of-laws-international-islamic-universi… (JabRef#4482)
22872d2 APA: Use "et al." in Dutch (JabRef#4484)
5f6c080 Update weed-research.csl (JabRef#4485)
b2fbe15 APA 7th edition (JabRef#4419)
c236ade Create BFCN.csl (JabRef#4481)
25d40cd Update iso690-full-note-cs.csl (JabRef#4480)
5de3904 Update budownictwo-i-architektura-pl.csl (JabRef#4479)
9d9c1da Add files via upload (JabRef#4478)
96200b0 Create instituto-alberto-luiz-coimbra-de-pos-graduacao-e-pesquisa-de-… (JabRef#4476)
8aa9cb0 Update APA journal styles (JabRef#4475)
8549afa Update in-text citation for legal_case for BJPS (JabRef#4470)
71c9e4d Update surgical-neurology-international.csl (JabRef#4472)
a9dac17 Create FUNDING.yml
633e864 Create helsingin-yliopisto-teologinen-tiedekunta-teologian-tyyli.csl (JabRef#4303)
8797c01 Create romanian-iso-690-full-note-with-ibid-romanian.csl (JabRef#4465)
c1519e1 Create assosiation-of-firearms-and-toolmark-examiners.csl (JabRef#4468)
c974e30 Update ieee.csl (JabRef#4467)
a1b7386 Update stale.yml (JabRef#4466)
db549dd Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-ser… (JabRef#4462)
2822437 Update .travis.yml (JabRef#4463)
3d72c62 WIP: Adding deprecation notice to DIN1505-2 saying it has been superseded by ISO 690 (JabRef#4454)
1928c2b Fix links after KI update
fad65b7 Turn Kidney International into AMA dependent
6357af5 Update association-for-computing-machinery.csl (JabRef#4459)
eab02ea Create berlin-school-of-economics-and-law-international-marketing-man… (JabRef#3774)
a3e3d97 One more metadata fix
e7d5071 Some Sheldon metadata fixes
3ad4260 Create jurnal-sains-farmasi-dan-klinis.csl (JabRef#4455)
46370dc Add "AIMS Press" journals (JabRef#4458)
57fca07 Update association-for-computing-machinery.csl (JabRef#4456)
6fa90ed Add "Muséum national d'Histoire naturelle" journal styles (JabRef#4457)
7faf0b0 Bundle update
e3c1f85 Create cryptogamie, bryologie (JabRef#4350)
525bba5 Create iso690-full-note-cs.csl (JabRef#4414)
932fad5 Create iso690-author-date-de.csl (JabRef#4344)
ab23108 Create mbts-fullnote-bibliography.csl (JabRef#4363)
c163008 Create associacao-brasileira-de-normas-tecnicas-ibict-full.csl (JabRef#4202)
5586bbc Create associacao-brasileira-de-normas-tecnicas-ibict-initials.csl (JabRef#4203)
483efcb Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-service-engineering.csl (JabRef#4442)
92f437d Create independent style for molecular-nutrition-and-food-research.csl… (JabRef#4342)
0d7f481 Update taylor-and-francis-council-of-science-editors-author-date.csl (JabRef#4385)
2b2786b Create ritid-timarit-hugvisindastofnunnar.csl (JabRef#4315)
9534999 Create jsbm.csl (JabRef#4371)
b390657 Changed term on access macro, added rules for bill (JabRef#4407)
95c24f9 Create ecausp-abnt.csl (JabRef#4420)
66ca962 Reindent/reorder
91fefee Create materials-express.csl (JabRef#4445)
ea5d50b Create institut-catholique-de-paris.csl (JabRef#4450)
a4c07e2 Create institut-catholique-de-paris.csl (JabRef#4374)
8a17ae0 Update canadian-geotechnical-journal.csl (JabRef#4447)
7165db0 Update ens-de-lyon-centre-d-ingenierie-documentaire.csl (JabRef#4448)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: e106215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web search input field does not work
2 participants
@tobiasdiez @Siedlerchr