Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix icon size - the second #4993

Merged
merged 2 commits into from
May 25, 2019
Merged

Fix icon size - the second #4993

merged 2 commits into from
May 25, 2019

Conversation

calixtus
Copy link
Member

The entry-editor showed a slightly smaller icon for the GenerateBibtexKey-Button, this bug also had an effect on the display of icon size in #4991

The GenerateBibtexKey-Button is now a Button like every other Button in FXML, the ActionObject was put into a standard-FXML-method. Everything works, including Undo and asking before overwriting.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@calixtus
Copy link
Member Author

Ready to review.

Siedlerchr
Siedlerchr approved these changes May 23, 2019
View reviewed changes
src/main/java/org/jabref/gui/actions/ActionFactory.java
@@ -148,13 +147,9 @@ public ButtonBase configureIconButton(Action action, Command command, ButtonBase
button.getStyleClass().add("icon-button");

// For some reason the graphic is not set correctly, so let's fix this
// ToDO: Find a way to reuse JabRefIconView
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the comments can be removed now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk, i just left it there, because I did not change anything in the bigger picture nor put JabRefIconView to some use here. I did not want to delete any reminder one of the earlier developers set.
I work pretty much the same: I write something, I realize, there could be a more elegant approach, but I don't want to loose focus on what I'm writing, so I just leave a ToDo.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label May 25, 2019
@Siedlerchr Siedlerchr merged commit 3ebc59a into JabRef:master May 25, 2019
@Siedlerchr
Copy link
Member

Thanks for the fix!

Siedlerchr added a commit that referenced this pull request May 25, 2019
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into convertSearchWorker
ef6b159 
* upstream/master:
  Fix icon size - the second (#4993)

# Conflicts:
#	src/main/java/org/jabref/gui/entryeditor/EntryEditor.java
Siedlerchr added a commit that referenced this pull request May 26, 2019
@Siedlerchr
Merge branch 'ieeFix' of github.com:JabRef/jabref into ieeFix
62553de 
* 'ieeFix' of github.com:JabRef/jabref:
  Fix the 'Attach file' dialog for starting on the user's main directory (#4996)
  Readme TOC (#4986)
  Fix icon size - the second (#4993)
  Fix background color of dialogs in dark mode (#4994)
  NPE-fix for Preferences/Ext-Prog/Settings for X/Browse  (#4983)
  Bump richtextfx from 0.10.0 to 0.10.1 (#4989)
  Bump tika-core from 1.20 to 1.21 (#4984)
  Resize different fonts changing entry type (#4980)
  Extended Hints - Alternative to #4971 (#4975)
  Fix command line help text (#4979)
@calixtus calixtus deleted the fix-icon-size2 branch May 27, 2019 21:14
github-actions bot pushed a commit that referenced this pull request Aug 27, 2020
Squashed 'src/main/resources/csl-styles/' changes from c8784ff..a8dafef
6f71ff5 
a8dafef Update harvard-cite-them-right.csl (#4993)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a8dafef
github-actions bot pushed a commit to RamonG92/jabref that referenced this pull request Sep 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from eb0d37e..fad76fe
0d5ad2a 
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to CaptainDaVinci/jabref that referenced this pull request Sep 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from eb0d37e..fad76fe
d721d0e 
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to dimitra-karadima/jabref that referenced this pull request Sep 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from eb0d37e..fad76fe
d54dd55 
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to Xuanxuan-Zou/jabref that referenced this pull request Sep 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from eb0d37e..fad76fe
eb015a2 
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to felixbohnacker/jabref that referenced this pull request Sep 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from eb0d37e..fad76fe
f2e4e56 
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to ShikunXiong/jabref that referenced this pull request Sep 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from eb0d37e..fad76fe
90ed62e 
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to eetian/jabref that referenced this pull request Sep 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from eb0d37e..fad76fe
0c776a4 
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to leitianjian/jabref that referenced this pull request Sep 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from eb0d37e..fad76fe
3ea0fd4 
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to systemoperator/jabref that referenced this pull request Sep 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from eb0d37e..fad76fe
4a971d9 
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to dextep/jabref that referenced this pull request Sep 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from eb0d37e..fad76fe
7c8e4e2 
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to graffaner/jabref that referenced this pull request Sep 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from eb0d37e..fad76fe
95f1044 
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to joe9111/jabref that referenced this pull request Sep 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from eb0d37e..fad76fe
763c60a 
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to NikodemKch/jabref-1 that referenced this pull request Sep 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from eb0d37e..fad76fe
a88f1a1 
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calixtus @Siedlerchr