Fix substring exception in find unlinked files #5142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor to own method and add test The exeption came when the parsed editor string did not end with a colon and two spaces
Siedlerchr
added
the
status: ready-for-review
…rter * upstream/master: Bump junit-vintage-engine from 5.5.0 to 5.5.1 Bump junit-jupiter from 5.5.0 to 5.5.1 Bump junit-platform-launcher from 1.5.0 to 1.5.1 Bump mysql-connector-java from 8.0.16 to 8.0.17
LinusDietz
approved these changes
Aug 1, 2019
tobiasdiez
requested changes
Aug 2, 2019
| // i points to the current line | ||
| // curString (mostly) contains the current block | ||
| // the different lines are joined into one and thereby separated by " " | ||
| lines = firstpageContents.split(lineSeparator); |
There was a problem hiding this comment.
Since this reads the content of the pdf file, you cannot expect the newlines to be of a particular form. Use something like
There was a problem hiding this comment.
Added this variant, merging now
…rter # By David Méndez (47) and others # Via GitHub (5) and David Méndez (3) * upstream/master: (57 commits) fix wrong package (#5181) Remove logging message for non-existing nested files Bump applicationinsights-core from 2.4.0 to 2.4.1 (#5171) Bump archunit-junit5-engine from 0.10.2 to 0.11.0 (#5157) Bump applicationinsights-logging-log4j2 from 2.4.0 to 2.4.1 (#5172) Bump tika-core from 1.21 to 1.22 (#5166) Fix fail on testPerformExportForSingleEntry from DocBook5ExporterTest (#5168) Add a check for nested files and improve the code to skip lines (DefaultTexParser) Add latest changes to latexintegration (#5170) LaTeX integration latest changes (#5167) Move to extended enums for fields and entry types (#5148) Bump archunit-junit5-api from 0.10.2 to 0.11.0 (#5158) Revert temporal change Fix all issues from reviews of #5137 Bump com.simonharrer.modernizer from 1.6.0-1 to 1.8.0-1 (#5154) Bump checkstyle from 8.22 to 8.23 (#5153) Add a new JabRefIcons.LATEX_CITATIONS Change toString() methods Update DefaultTexParser for explaining when and why it skips the citation matching Update TexParserResult for avoiding 'orElse(null)' ... # Conflicts: # src/main/java/org/jabref/logic/importer/fileformat/PdfContentImporter.java # src/test/java/org/jabref/logic/importer/fileformat/PdfContentImporterTest.java
add unify line breaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor to own method and add test
The exception came when the parsed editor string did not end with a colon and two spaces
Fixes #5128