Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move journal abbreviations to library #5977

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Move journal abbreviations to library #5977

merged 1 commit into from
Feb 27, 2020

Conversation

stefan-kolb
Copy link
Member

@stefan-kolb stefan-kolb commented Feb 21, 2020 •
edited
Loading

Previously:
image

Now:
image

Closes JabRef#398

@koppor koppor added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers ui labels Feb 21, 2020
@tobiasdiez
Copy link
Member

For me this better fits under Tools (or maybe Quality). There is really nothing specific to "library" in abbreviation journal names. It's specific to the selected entries and not a global.

@stefan-kolb
Copy link
Member Author

stefan-kolb commented Feb 24, 2020 •
edited
Loading

It's specific to the selected entries and not a global.

You got a point here!

Maybe it needs to stay. It might be more edit related then but our edit menu grows more and more then...

@koppor
Copy link
Member

koppor commented Feb 24, 2020

We saw this point also last week. Forgot to add it to JabRef#398.

+1 for Quality

because

  • Tools is more external-related (files, sync, import/export)
  • Edit grows too large
  • Library is for the complete library

@koppor
Copy link
Member

koppor commented Feb 26, 2020

Decision: move to "Quality"

@stefan-kolb
Move journal abbreviations to quality
d84bce7 
Idea: tools should be mostly external integrations in the future
@tobiasdiez tobiasdiez added this to the v5.0 milestone Feb 27, 2020
@stefan-kolb stefan-kolb merged commit 3431490 into master Feb 27, 2020
@stefan-kolb stefan-kolb deleted the journal-actions branch February 27, 2020 12:03
koppor pushed a commit that referenced this pull request Apr 1, 2022
Squashed 'buildres/csl/csl-styles/' changes from 6a7b708..21e2177
21de2bf 
21e2177 Create respiratory-care-journal.csl (#5998)
d0a2846 Update archaeonautica.csl (#5987)
664784e Update cardiff-university-harvard.csl (#5982)
07ce91e improve journal-of-avian-biology.csl (#5984)
349a5d6 update based on latest version of ISO 690 standard (#5976)
d8c3725 Update mary-ann-liebert-vancouver.csl (#5981)
7b2e70d Update style-manual-australian-government.csl (#5975)
bebf50c Create extracellular-vesicles-and-circulating-nucleic-acids.csl (#5979)
cabcdd4 Update united-states-international-trade-commission.csl (#5967)
948c48a Update cardiff-university-harvard.csl (#5977)
d6bf535 Add name to label gun
cf0d930 Test label gun
2f40fcd Update the-journal-of-egyptian-archaeology.csl (#5964)
aa023e1 Create materials-research-society-bulletin.csl (#5917)
ea31783 Changed quotation marks to Spanish ones (#5968)
27245f9 AJA: Add "." suffix to citation layout. (#5971)
7726a40 Update american-medical-association.csl (#5970)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 21e2177
Siedlerchr pushed a commit that referenced this pull request Apr 1, 2022
@koppor
Squashed 'buildres/csl/csl-styles/' changes from 6a7b708..21e2177 (#8632
c4d01bf 
)

21e2177 Create respiratory-care-journal.csl (#5998)
d0a2846 Update archaeonautica.csl (#5987)
664784e Update cardiff-university-harvard.csl (#5982)
07ce91e improve journal-of-avian-biology.csl (#5984)
349a5d6 update based on latest version of ISO 690 standard (#5976)
d8c3725 Update mary-ann-liebert-vancouver.csl (#5981)
7b2e70d Update style-manual-australian-government.csl (#5975)
bebf50c Create extracellular-vesicles-and-circulating-nucleic-acids.csl (#5979)
cabcdd4 Update united-states-international-trade-commission.csl (#5967)
948c48a Update cardiff-university-harvard.csl (#5977)
d6bf535 Add name to label gun
cf0d930 Test label gun
2f40fcd Update the-journal-of-egyptian-archaeology.csl (#5964)
aa023e1 Create materials-research-society-bulletin.csl (#5917)
ea31783 Changed quotation marks to Spanish ones (#5968)
27245f9 AJA: Add "." suffix to citation layout. (#5971)
7726a40 Update american-medical-association.csl (#5970)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 21e2177

Co-authored-by: github actions <jabrefmail+webfeedback@gmail.com>
koppor pushed a commit that referenced this pull request Apr 15, 2022
Squashed 'buildres/csl/csl-styles/' changes from 6a7b708..9ff3112
9d994ae 
9ff3112 Update bibtex.csl (#6021)
68ed5f7 Don't initialize with hyphen in Vancouver/NLM (#6022)
80206ad Update american-physics-society.csl (#5934)
cfbdba6 Update csl style (#6003)
546ee88 Update institut-francais-darcheologie-orientale-en.csl (#6018)
1153e3e Update institut-francais-darcheologie-orientale-etudes-arabes.csl (#6019)
42d5031 Update institut-francais-darcheologie-orientale-arab-studies.csl (#6020)
2e10c7a Update institut-francais-darcheologie-orientale.csl (#6015)
0c7d6a1 Create science-china-materials.csl (#6017)
0eb4bc7 Update frontiers.csl (#6014)
0fd9cc2 Update urad-rs-za-makroekonomske-analize-in-razvoj.csl (#5963)
1393837 Update harvard-university-of-the-west-of-england.csl (#6013)
4474b0e Update frontiers-of-biogeography.csl (#6010)
736c6df Render status field (for forthcoming, in press, etc.) to date groups (#6005)
51ff3dc Create journal-of-contemporary-water-research-and-education.csl (#5912)
7387ed3 cell.csl: Add a macro for DOI and webpage accessed date. (#5999)
21e2177 Create respiratory-care-journal.csl (#5998)
d0a2846 Update archaeonautica.csl (#5987)
664784e Update cardiff-university-harvard.csl (#5982)
07ce91e improve journal-of-avian-biology.csl (#5984)
349a5d6 update based on latest version of ISO 690 standard (#5976)
d8c3725 Update mary-ann-liebert-vancouver.csl (#5981)
7b2e70d Update style-manual-australian-government.csl (#5975)
bebf50c Create extracellular-vesicles-and-circulating-nucleic-acids.csl (#5979)
cabcdd4 Update united-states-international-trade-commission.csl (#5967)
948c48a Update cardiff-university-harvard.csl (#5977)
d6bf535 Add name to label gun
cf0d930 Test label gun
2f40fcd Update the-journal-of-egyptian-archaeology.csl (#5964)
aa023e1 Create materials-research-society-bulletin.csl (#5917)
ea31783 Changed quotation marks to Spanish ones (#5968)
27245f9 AJA: Add "." suffix to citation layout. (#5971)
7726a40 Update american-medical-association.csl (#5970)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 9ff3112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

@koppor koppor Awaiting requested review from koppor

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers ui
Projects
None yet
Milestone
v5.0
Development

Successfully merging this pull request may close these issues.

Move journal abbreviations to library menu
3 participants
@stefan-kolb @tobiasdiez @koppor