Add graal info to module file #6010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasdiez
added
the
status: ready-for-review
|
/home/runner/work/jabref/jabref/src/main/java/module-info.java:67: error: module not found: org.graalvm.js.scriptengine |
|
Still no sucess: Btw, you can directly test this locally if you just call gradlew jlink and then run it from the bat |
…hel-kraemer/jabref into graal * 'citeproc-java-2.1.0-SNAPSHOT' of https://github.com/michel-kraemer/jabref: Update citeproc-java to 2.1.0-SNAPSHOT and enable experimental pure-Java mode
|
Seems to be a bug in graal which got resolved in 19.3.0: oracle/graal#1751 |
|
Yippieh, it works now! 🚨 🎉 😀 @michel-kraemer I got it to work, but for one entry it throws the following exception: For this entry: |
5 tasks
|
All tests performed with |
koppor
reviewed
Feb 27, 2020
Sure. Shouldn't be a larger problem. Do you need it urgently? If so, I can do it on the weekend. If not, I'd prefer to do it on the next weekend after my paper deadline :) |
|
@michel-kraemer As it's working now in general, I don't think it's anylonger necessary to update graal urgently. |
|
@Siedlerchr Great! Let me know if you find bugs in the pure Java implementation. Also, if you need a fixed version (i.e. a beta.1 instead of a SNAPSHOT), just contact me. |
|
@michel-kraemer This entry created an exception #6010 (comment) And when creating a new entry with empty fields I got an exception as well. I will check later for details again. But also tested with another database and that worked fine so far. |
5 tasks
|
@Siedlerchr May I ask you to create issues in the citeproc-java repo (https://github.com/michel-kraemer/citeproc-java), so we can keep track of the fixes? Thanks! |
Siedlerchr
added a commit
that referenced
this pull request
Mar 6, 2020
* upstream/master: Remove "Merge Entries" from Quality Menu (#6021) Raise codecov threshold (#6027) Translation for SpecialField names in preferences (#6031) Fix dependency updates workflow (#6033) Add graal info to module file (#6010) Group remote database actions in menu Move journal abbreviations to quality
koppor
reviewed
Mar 17, 2020
| @@ -46,6 +46,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `# | |||
| - We fixed an issue where changing entry type doesn't always work when biblatex source is shown. [#5905](https://github.com/JabRef/jabref/issues/5905) | |||
| - We fixed an issue where the group and the link column were not updated after changing the entry in the main table. [#5985](https://github.com/JabRef/jabref/issues/5985) | |||
| - We fixed an issue where reordering the groups was not possible after inserting an article. [#6008](https://github.com/JabRef/jabref/issues/6008) | |||
| - We fixed an issue where citation styles except the default "Preview" could not be used. [#56220](https://github.com/JabRef/jabref/issues/5622) | |||
There was a problem hiding this comment.
Isn't the default preview mode based on our export filter capability? See https://docs.jabref.org/setup/preview
I would suggest to remove "except..." or reword to: "citation styles stopped working"
koppor
reviewed
Jan 7, 2021
| requires org.graalvm.truffle; | ||
| requires org.graalvm.sdk; | ||
| requires transitive org.graalvm.js; | ||
| requires java.scripting; |
There was a problem hiding this comment.
I thought that 2.1.0-SNAPSHOT does not require JavaScript anymore (see also michel-kraemer/citeproc-java#92). @tobiasdiez Do you remember why you had to add these dependencies?
koppor
pushed a commit
that referenced
this pull request
Apr 15, 2022
9ff3112 Update bibtex.csl (#6021) 68ed5f7 Don't initialize with hyphen in Vancouver/NLM (#6022) 80206ad Update american-physics-society.csl (#5934) cfbdba6 Update csl style (#6003) 546ee88 Update institut-francais-darcheologie-orientale-en.csl (#6018) 1153e3e Update institut-francais-darcheologie-orientale-etudes-arabes.csl (#6019) 42d5031 Update institut-francais-darcheologie-orientale-arab-studies.csl (#6020) 2e10c7a Update institut-francais-darcheologie-orientale.csl (#6015) 0c7d6a1 Create science-china-materials.csl (#6017) 0eb4bc7 Update frontiers.csl (#6014) 0fd9cc2 Update urad-rs-za-makroekonomske-analize-in-razvoj.csl (#5963) 1393837 Update harvard-university-of-the-west-of-england.csl (#6013) 4474b0e Update frontiers-of-biogeography.csl (#6010) 736c6df Render status field (for forthcoming, in press, etc.) to date groups (#6005) 51ff3dc Create journal-of-contemporary-water-research-and-education.csl (#5912) 7387ed3 cell.csl: Add a macro for DOI and webpage accessed date. (#5999) 21e2177 Create respiratory-care-journal.csl (#5998) d0a2846 Update archaeonautica.csl (#5987) 664784e Update cardiff-university-harvard.csl (#5982) 07ce91e improve journal-of-avian-biology.csl (#5984) 349a5d6 update based on latest version of ISO 690 standard (#5976) d8c3725 Update mary-ann-liebert-vancouver.csl (#5981) 7b2e70d Update style-manual-australian-government.csl (#5975) bebf50c Create extracellular-vesicles-and-circulating-nucleic-acids.csl (#5979) cabcdd4 Update united-states-international-trade-commission.csl (#5967) 948c48a Update cardiff-university-harvard.csl (#5977) d6bf535 Add name to label gun cf0d930 Test label gun 2f40fcd Update the-journal-of-egyptian-archaeology.csl (#5964) aa023e1 Create materials-research-society-bulletin.csl (#5917) ea31783 Changed quotation marks to Spanish ones (#5968) 27245f9 AJA: Add "." suffix to citation layout. (#5971) 7726a40 Update american-medical-association.csl (#5970) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 9ff3112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5246 Fixes #5622
As mentioned by @michel-kraemer in https://github.com/JabRef/jabref#issuecomment-590334280 the error might result from a non-present module description. Not sure if the one I took covers everything. (@michel-kraemer do you remember what to add exactly?)