Add missing abbreviated journal names #6292

mayrmt · 2020-04-15T10:30:22Z

Add more abbreviated journal names. Details:

Also fix some typos in existing journal abbreviations.

Change in CHANGELOG.md described (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

Full name: Advanced Modeling and Simulation in Engineering Sciences Url: https://amses-journal.springeropen.com/

Full name: Applications of Mathematics Url: https://www.springer.com/journal/10492

Full name: Integrating Materials and Manufacturing Innovation Url: https://www.springer.com/journal/40192/

Full name: Numerical Linear Algebra with Applications Url: https://onlinelibrary.wiley.com/journal/10991506

Full name: SIAM Journal on Scientific and Statistical Computing Url: https://epubs.siam.org/loi/sijcd4

Full name: Engineering Computations Url: https://www.emerald.com/insight/publication/issn/0264-4401

Full name: Journal of Computational Science Url: https://www.journals.elsevier.com/journal-of-computational-science

Full name: Computational Materials Science Url: https://www.journals.elsevier.com/computational-materials-science

mayrmt · 2020-04-15T12:49:02Z

I don't understand, why coverage is supposedly going down. According to the codecov details, this PR only changes files, that are ignored by the code coverage tool.

I'd appreciate any insight and help. Thanks!

koppor · 2020-04-15T19:25:43Z

CodeCov decreased, because the SpringerFetcher failed this time:
. Think, we have to reconfigure CodeCov to test "only" the "local" functionality - and not the one relying on external life services (AKA integration test).

Update: Not that easily possible, but I tried 01189ef.

koppor · 2020-04-15T19:28:24Z

@jlaehne You have deep knowledge about the abbreviatins (refs #5749). Could you guide @mayrmt here? Should he also add the abbreviations somewhere at https://github.com/JabRef/abbrv.jabref.org/?

From my side, I would just merge. However, I fear that the abbreviations get lost if we continue working on #5749

jlaehne · 2020-04-15T19:47:26Z

src/main/resources/journals/journalList.csv

@@ -450,6 +450,7 @@ Advanced Materials;Adv. Mater.;;
 Advanced Materials and Processes;Adv. Mater. Processes;;
 Advanced Materials for Optics and Electronics;Adv. Mater. Opt. Electron.;;
 Advanced Materials Forum;Adv. Mater. Forum;;
+Advanced Modeling and Simulation in Engineering Sciences;Adv. Model. and Simul. in Eng. Sci.;;


and or in are left out in the ISO specs, so I would expect Adv. Model. Simul. Eng. Sci.

@jlaehne You're right. I will fix this.

jlaehne · 2020-04-15T20:01:13Z

@mayrmt, could you add your abbreviations/corrections to https://github.com/JabRef/abbrv.jabref.org/blob/master/journals/journal_abbreviations_ams.csv

and verify that, if present, they are also correct in https://github.com/JabRef/abbrv.jabref.org/blob/master/journals/journal_abbreviations_general.csv
(has higher priority over the other lists)

As @koppor indicated, with #5749, corrections will be automatically sourced from the lists at JabRef/abbrv.jabref.org and, if just merged into the overall list at the moment, your corrections would be lost in the future.

mayrmt · 2020-04-15T21:24:05Z

@jlaehne I've removed some "and" from abbreviated names. I'm happy to squash these 11 commits into one, if desired. Just let me know.

Furthermore, JabRef/abbrv.jabref.org#61 mirrors these changes.

jlaehne · 2020-04-15T21:40:11Z

Thanks for the mirroring

koppor · 2020-04-16T20:11:58Z

I'll use GitHub's "Squash and merge" functionality. Thank you for the Update!

This reverts commit 38687aa

…ionCaseInsensitive * upstream/master: (25 commits) ActionHelper to test for present file (#6151) Reduce memory footprint (#6298) Add missing abbreviated journal names (#6292) fix l10n again fix checkstyle fix l10n Try to minimize CodeCov "wrong metrics" Showing correct icon on main table linked files column (#6264) Fix labels for outdated dependency issue Change one more line Squashed 'src/main/resources/csl-styles/' changes from c31d9ca..c1793d2 Resolve unit test from failing Add one more change Fix errors RIS import takes the wrong date and duplicates abstract (#6272) Update EntryTypeView.java Change to the old school format Fix XmpExporterTest (#6289) Add checkstyle screenshot (and lint guidelines-...md) Squashed 'src/main/resources/csl-styles/' changes from db54e56..c31d9ca ...

This reverts commit 38687aa

43566f2 Update molecular-oncology.csl (#6354) 38f2b5f Update san-francisco-estuary-and-watershed-science.csl (#6350) 724cb12 Update australasian-journal-of-philosophy.csl (#6344) df6af86 Fix webpage in-text citation for council-of-science-editors-author-date.csl (#6318) 6900b58 Add month to magazine for Bluebook e0a8148 Update cambridge-university-press-author-date-cambridge-a.csl (#6345) 0823448 Add space & comma before pp (#6343) ff38cd2 Update american-journal-of-respiratory-and-critical-care-medicine.csl (#6341) 8727dfb Update early-music-history.csl (#6323) 1154354 Update boletin-de-pediatria.csl (#6310) f25438e Update pravnik.csl (#6309) db7a4ae Update zoological-journal-of-the-linnean-society.csl (#6304) 6c043a7 Create polygraphia.csl (#6307) 255e00c Create intellect-newgen-books.csl (#6308) 323629f Update historical-materialism.csl (#6300) f62b70d Create european-review-of-international-studies.csl (#6301) dff2698 Update ucl-university-college-harvard.csl (#6298) 0ce09c9 Update sciences-po-ecole-doctorale-note-french.csl (#6290) bdd53ec Update sciences-po-ecole-doctorale-author-date.csl (#6291) efde4d4 Create journal-of-law-medicine-ethics.csl (#6296) 7539b2c Create theses-de-sorbonne-universite.csl (#6295) 905f25a Update biochemical-society-transactions.csl (#6292) a76a3f5 Update smithsonian-institution-scholarly-press author-date and note (#6294) e6b6c6c Create exploration-of-targeted-anti-tumor-therapy.csl (#6276) 024c9c8 Create nys-nydanske-studier.csl (#6331) d9ac8e1 Update vox-sanguinis.csl (#6327) 9a98e92 Remove DOI from Genetics & Molecular Biology git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 43566f2

mayrmt added 10 commits April 15, 2020 12:20

Add journal abbreviation for AMSES

4c95914

Full name: Advanced Modeling and Simulation in Engineering Sciences Url: https://amses-journal.springeropen.com/

Add journal abbreviation for "Appl. Math."

4f24c94

Full name: Applications of Mathematics Url: https://www.springer.com/journal/10492

Add another journal

8af67d5

Full name: Integrating Materials and Manufacturing Innovation Url: https://www.springer.com/journal/40192/

Add journal abbreviation for NLAA

ab407b4

Full name: Numerical Linear Algebra with Applications Url: https://onlinelibrary.wiley.com/journal/10991506

Add journal abbreviation of another SIAM journal

0d1f4a3

Full name: SIAM Journal on Scientific and Statistical Computing Url: https://epubs.siam.org/loi/sijcd4

Add journal abbrev for "Engineering Computations"

d667a6c

Full name: Engineering Computations Url: https://www.emerald.com/insight/publication/issn/0264-4401

Add abbrev for "Journal of Computational Science"

fe331c4

Full name: Journal of Computational Science Url: https://www.journals.elsevier.com/journal-of-computational-science

Fix abbreviation of journal "Climatic Change"

2153158

Add abbrev for "Computational Materials Science"

b8a6e32

Full name: Computational Materials Science Url: https://www.journals.elsevier.com/computational-materials-science

Insert missing space in journal abbreviation

6ded58c

jlaehne reviewed Apr 15, 2020

View reviewed changes

Remove some 'and' from ISO abbreviations

4842498

mayrmt mentioned this pull request Apr 15, 2020

Add some journals JabRef/abbrv.jabref.org#61

Merged

koppor merged commit 4a9247b into JabRef:master Apr 16, 2020

mayrmt deleted the add-abbrev-journal-names branch April 16, 2020 20:38

dextep pushed a commit to dextep/jabref that referenced this pull request Apr 17, 2020

Add missing abbreviated journal names (JabRef#6292)

38687aa

dextep added a commit to dextep/jabref that referenced this pull request Apr 17, 2020

Revert "Add missing abbreviated journal names (JabRef#6292)"

23d9720

This reverts commit 38687aa

dextep added a commit to dextep/jabref that referenced this pull request May 3, 2020

Revert "Add missing abbreviated journal names (JabRef#6292)"

8a510e3

This reverts commit 38687aa

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing abbreviated journal names #6292

Add missing abbreviated journal names #6292

mayrmt commented Apr 15, 2020 •

edited

Loading

mayrmt commented Apr 15, 2020

koppor commented Apr 15, 2020 •

edited

Loading

koppor commented Apr 15, 2020

jlaehne Apr 15, 2020

mayrmt Apr 15, 2020

jlaehne commented Apr 15, 2020

mayrmt commented Apr 15, 2020

jlaehne commented Apr 15, 2020

koppor commented Apr 16, 2020

Add missing abbreviated journal names #6292

Add missing abbreviated journal names #6292

Conversation

mayrmt commented Apr 15, 2020 • edited Loading

mayrmt commented Apr 15, 2020

koppor commented Apr 15, 2020 • edited Loading

koppor commented Apr 15, 2020

jlaehne Apr 15, 2020

Choose a reason for hiding this comment

mayrmt Apr 15, 2020

Choose a reason for hiding this comment

jlaehne commented Apr 15, 2020

mayrmt commented Apr 15, 2020

jlaehne commented Apr 15, 2020

koppor commented Apr 16, 2020

mayrmt commented Apr 15, 2020 •

edited

Loading

koppor commented Apr 15, 2020 •

edited

Loading