Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove caching in deployment scripts #6309

Merged
merged 1 commit into from
Apr 18, 2020
Merged

Remove caching in deployment scripts #6309

merged 1 commit into from
Apr 18, 2020

Conversation

tobiasdiez
Copy link
Member

Recently our build script fails and often the reason is a problem with the cache. https://github.com/JabRef/jabref/runs/597567964 Let's see if it works without caching.

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 18, 2020
@tobiasdiez
Copy link
Member Author

I'll merge now directly because the build is successful and actually faster than with the cache (https://github.com/JabRef/jabref/runs/597567973?check_suite_focus=true needed 5min longer because restoring / saving the cache takes quite long).

@tobiasdiez tobiasdiez merged commit 5816f94 into master Apr 18, 2020
@tobiasdiez tobiasdiez deleted the removeCacheBuild branch April 18, 2020 11:15
@koppor
Copy link
Member

koppor commented May 12, 2020

Because of this, we are blocked by jcenter or maven central, because of high traffic load.

Build runtime image
4m 57s
	at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:38)
* What went wrong:
Execution failed for task ':compileJava'.
> Could not resolve all files for configuration ':compileClasspath'.
   > Could not resolve org.apache.logging.log4j:log4j-jcl:3.0.0-SNAPSHOT.
     Required by:
         project :
      > Could not resolve org.apache.logging.log4j:log4j-jcl:3.0.0-SNAPSHOT.
         > Could not get resource 'https://repository.apache.org/snapshots/org/apache/logging/log4j/log4j-jcl/3.0.0-SNAPSHOT/log4j-jcl-3.0.0-20200510.182830-557.pom'.
            > Could not GET 'https://repository.apache.org/snapshots/org/apache/logging/log4j/log4j-jcl/3.0.0-SNAPSHOT/log4j-jcl-3.0.0-20200510.182830-557.pom'.
               > Read timed out
   > Could not resolve org.apache.logging.log4j:log4j-slf4j18-impl:3.0.0-SNAPSHOT.
     Required by:
         project :
      > Could not resolve org.apache.logging.log4j:log4j-slf4j18-impl:3.0.0-SNAPSHOT.
         > Unable to load Maven meta-data from https://repository.apache.org/snapshots/org/apache/logging/log4j/log4j-slf4j18-impl/3.0.0-SNAPSHOT/maven-metadata.xml.
            > Could not get resource 'https://repository.apache.org/snapshots/org/apache/logging/log4j/log4j-slf4j18-impl/3.0.0-SNAPSHOT/maven-metadata.xml'.
               > Could not GET 'https://repository.apache.org/snapshots/org/apache/logging/log4j/log4j-slf4j18-impl/3.0.0-SNAPSHOT/maven-metadata.xml'.
                  > Connection reset
   > Could not resolve org.apache.logging.log4j:log4j-plugins:3.0.0-SNAPSHOT.
     Required by:
         project :
      > Could not resolve org.apache.logging.log4j:log4j-plugins:3.0.0-SNAPSHOT.
         > Unable to load Maven meta-data from https://repository.apache.org/snapshots/org/apache/logging/log4j/log4j-plugins/3.0.0-SNAPSHOT/maven-metadata.xml.

@koppor
Copy link
Member

koppor commented May 12, 2020

Tweeted about it - let's see

.@github Is there a blog entry or help page explaining why building with #githubactions caching is considerably slower than without any cache? Refs #6309.

— Oliver Kopp (@koppor) May 12, 2020

@koppor koppor removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label May 12, 2020
koppor pushed a commit that referenced this pull request Jan 1, 2023
43566f2 Update molecular-oncology.csl (#6354)
38f2b5f Update san-francisco-estuary-and-watershed-science.csl (#6350)
724cb12 Update australasian-journal-of-philosophy.csl (#6344)
df6af86 Fix webpage in-text citation for council-of-science-editors-author-date.csl (#6318)
6900b58 Add month to magazine for Bluebook
e0a8148 Update cambridge-university-press-author-date-cambridge-a.csl (#6345)
0823448 Add space & comma before pp (#6343)
ff38cd2 Update american-journal-of-respiratory-and-critical-care-medicine.csl (#6341)
8727dfb Update early-music-history.csl (#6323)
1154354 Update boletin-de-pediatria.csl (#6310)
f25438e Update pravnik.csl (#6309)
db7a4ae Update zoological-journal-of-the-linnean-society.csl (#6304)
6c043a7 Create polygraphia.csl (#6307)
255e00c Create intellect-newgen-books.csl (#6308)
323629f Update historical-materialism.csl (#6300)
f62b70d Create european-review-of-international-studies.csl (#6301)
dff2698 Update ucl-university-college-harvard.csl (#6298)
0ce09c9 Update sciences-po-ecole-doctorale-note-french.csl (#6290)
bdd53ec Update sciences-po-ecole-doctorale-author-date.csl (#6291)
efde4d4 Create journal-of-law-medicine-ethics.csl (#6296)
7539b2c Create theses-de-sorbonne-universite.csl (#6295)
905f25a Update biochemical-society-transactions.csl (#6292)
a76a3f5 Update smithsonian-institution-scholarly-press author-date and note (#6294)
e6b6c6c Create exploration-of-targeted-anti-tumor-therapy.csl (#6276)
024c9c8 Create nys-nydanske-studier.csl (#6331)
d9ac8e1 Update vox-sanguinis.csl (#6327)
9a98e92 Remove DOI from Genetics & Molecular Biology

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 43566f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants