Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch by ID: SAO/NASA Astrophysics Data System -> SAO/NASA ADS #6876

Merged
merged 3 commits into from
Sep 6, 2020
Merged

Fetch by ID: SAO/NASA Astrophysics Data System -> SAO/NASA ADS #6876

merged 3 commits into from
Sep 6, 2020

Conversation

mlep
Copy link
Contributor

@mlep mlep commented Sep 4, 2020

In drop-down menu for fetching by ID of the window "Select entry type", "SAO/NASA Astrophysics Data System" is quite long.
Replacement by SAO/NASA ADS (people knowing it will recognized it).

  • Change in CHANGELOG.md described (if applicable)

None of these items...:

  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

In drop-down menu for fetching by ID of the window "Select entry type", "SAO/NASA Astrophysics Data System" is quite long.
Replacement by SAO/NASA ADS 
(people knowing it will recognized it).

Remark: second PR coming to complement this one
@Siedlerchr
Copy link
Member

Plase also add changelog entry.

@mlep
Copy link
Contributor Author

mlep commented Sep 6, 2020

Added to changelog (ar first I thought this minimal change would not require it)

@Siedlerchr Siedlerchr merged commit c0b139a into JabRef:master Sep 6, 2020
@Siedlerchr
Copy link
Member

Thanks, probably a minor issue, but just for information purposes

@mlep mlep deleted the patch-6 branch September 10, 2020 14:00
Siedlerchr added a commit that referenced this pull request Sep 12, 2020
* upstream/master:
  Fix sort order in main table not stored (#6898)
  Window "Manage field names & content": make title consistent with menu (+ localization) (#6895)
  Complete rebranding of `bibtexkey` as `citationkey` (#6875)
  Dev-doc: ADR list (#6887)
  Bump lucene-queryparser from 8.6.1 to 8.6.2 (#6881)
  Bump fontbox from 2.0.20 to 2.0.21 (#6883)
  Bump org.beryx.jlink from 2.21.3 to 2.21.4 (#6882)
  Bump com.github.ben-manes.versions from 0.29.0 to 0.30.0 (#6884)
  Bump pdfbox from 2.0.20 to 2.0.21 (#6885)
  Bump mockito-core from 3.5.7 to 3.5.10 (#6886)
  lint changelog
  Dev Doc: Moving around ADR (end?) (#6873)
  Add MD031 to lint ignore list
  Add mlep's other email adress
  Fetch by ID: SAO/NASA Astrophysics Data System -> SAO/NASA ADS (#6876)
Siedlerchr added a commit that referenced this pull request Sep 12, 2020
* upstream/master: (55 commits)
  Fix sort order in main table not stored (#6898)
  Window "Manage field names & content": make title consistent with menu (+ localization) (#6895)
  Complete rebranding of `bibtexkey` as `citationkey` (#6875)
  Dev-doc: ADR list (#6887)
  Bump lucene-queryparser from 8.6.1 to 8.6.2 (#6881)
  Bump fontbox from 2.0.20 to 2.0.21 (#6883)
  Bump org.beryx.jlink from 2.21.3 to 2.21.4 (#6882)
  Bump com.github.ben-manes.versions from 0.29.0 to 0.30.0 (#6884)
  Bump pdfbox from 2.0.20 to 2.0.21 (#6885)
  Bump mockito-core from 3.5.7 to 3.5.10 (#6886)
  lint changelog
  Dev Doc: Moving around ADR (end?) (#6873)
  Add MD031 to lint ignore list
  Add mlep's other email adress
  Fetch by ID: SAO/NASA Astrophysics Data System -> SAO/NASA ADS (#6876)
  Reimport -> Reload (#6874)
  GitBook: [master] 19 pages and 4 assets modified
  Add new author
  Delete .Rhistory
  Fix icon issue (#6858)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants