Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window "Manage field names & content": make title consistent with menu (+ localization) #6895

Merged
merged 4 commits into from
Sep 9, 2020

Conversation

mlep
Copy link
Contributor

@mlep mlep commented Sep 9, 2020

With Edit -> Manage field names & content, a window opened, with the title "Set/clear/append/rename".
Window title updated to match the menu.
The window title was not translated ==> Localization instruction added.

Please alter as needed (I am no Java programmer).

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, should work

@Siedlerchr Siedlerchr merged commit 46e9fe2 into JabRef:master Sep 9, 2020
@mlep
Copy link
Contributor Author

mlep commented Sep 9, 2020

Thanks!

@mlep mlep deleted the patch-9 branch September 10, 2020 14:00
Siedlerchr added a commit that referenced this pull request Sep 12, 2020
* upstream/master:
  Fix sort order in main table not stored (#6898)
  Window "Manage field names & content": make title consistent with menu (+ localization) (#6895)
  Complete rebranding of `bibtexkey` as `citationkey` (#6875)
  Dev-doc: ADR list (#6887)
  Bump lucene-queryparser from 8.6.1 to 8.6.2 (#6881)
  Bump fontbox from 2.0.20 to 2.0.21 (#6883)
  Bump org.beryx.jlink from 2.21.3 to 2.21.4 (#6882)
  Bump com.github.ben-manes.versions from 0.29.0 to 0.30.0 (#6884)
  Bump pdfbox from 2.0.20 to 2.0.21 (#6885)
  Bump mockito-core from 3.5.7 to 3.5.10 (#6886)
  lint changelog
  Dev Doc: Moving around ADR (end?) (#6873)
  Add MD031 to lint ignore list
  Add mlep's other email adress
  Fetch by ID: SAO/NASA Astrophysics Data System -> SAO/NASA ADS (#6876)
Siedlerchr added a commit that referenced this pull request Sep 12, 2020
* upstream/master: (55 commits)
  Fix sort order in main table not stored (#6898)
  Window "Manage field names & content": make title consistent with menu (+ localization) (#6895)
  Complete rebranding of `bibtexkey` as `citationkey` (#6875)
  Dev-doc: ADR list (#6887)
  Bump lucene-queryparser from 8.6.1 to 8.6.2 (#6881)
  Bump fontbox from 2.0.20 to 2.0.21 (#6883)
  Bump org.beryx.jlink from 2.21.3 to 2.21.4 (#6882)
  Bump com.github.ben-manes.versions from 0.29.0 to 0.30.0 (#6884)
  Bump pdfbox from 2.0.20 to 2.0.21 (#6885)
  Bump mockito-core from 3.5.7 to 3.5.10 (#6886)
  lint changelog
  Dev Doc: Moving around ADR (end?) (#6873)
  Add MD031 to lint ignore list
  Add mlep's other email adress
  Fetch by ID: SAO/NASA Astrophysics Data System -> SAO/NASA ADS (#6876)
  Reimport -> Reload (#6874)
  GitBook: [master] 19 pages and 4 assets modified
  Add new author
  Delete .Rhistory
  Fix icon issue (#6858)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants