Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up the "Aux file" on "Edit group" doesn't support relative sub-directories path #7950

Merged
merged 12 commits into from
Aug 2, 2021

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Jul 31, 2021

Follow-up PR from #7728 Closes #7728
Fixes #7719

I just added a test

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • [] Screenshots added in PR description (for UI changes)
  • [] Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

devinluo27 and others added 11 commits May 10, 2021 22:31
Co-authored-by: Jonatan Asketorp <2598631+k3KAW8Pnf7mkmdSMPHz27@users.noreply.github.com>
…o alooful

* 'fix_for_7719' of https://github.com/aloofluo/jabref:
  fixes for 7719, delete a comment
  fixes for 7719, reject if no LatexGroupPath is set
  Update src/main/java/org/jabref/gui/groups/GroupDialogViewModel.java
  fix for issue #7719, v3
  fix for issue #7719, v1
  fix for issue #7719, user should input absolute path
@Siedlerchr
Copy link
Member Author

Codacy is complaininig about the throws Exception in the test...^^

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 1, 2021
@koppor koppor merged commit f713d94 into main Aug 2, 2021
@koppor koppor deleted the alooful branch August 2, 2021 18:12
@calixtus calixtus removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "Aux file" on "Edit group" doesn't support relative sub-directories path
4 participants