Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update citeproc to fix CSL render exceptions #8532

Merged
merged 16 commits into from
Mar 14, 2022
Merged

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Feb 26, 2022

Fixes #8421
Fixes #8381

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr closed this Feb 26, 2022
@Siedlerchr Siedlerchr reopened this Feb 26, 2022
@Siedlerchr
Copy link
Member Author

Need to test the binary

@Siedlerchr
Copy link
Member Author

Seems to be something wrong wih the classpath loading inside csl. Damn

Siedlerchr and others added 5 commits March 7, 2022 19:28
* upstream/main:
  Bump guava from 31.0.1-jre to 31.1-jre (#8543)
  Bump org.beryx.jlink from 2.24.4 to 2.25.0 (#8548)
  Bump postgresql from 42.3.2 to 42.3.3 (#8546)
  Bump richtextfx from 0.10.7 to 0.10.9 (#8547)
  Bump archunit-junit5-engine from 0.22.0 to 0.23.1 (#8545)
  Bump actions/checkout from 2 to 3 (#8542)
  Squashed 'buildres/csl/csl-styles/' changes from eb97405..8f69d4e
  Bump classgraph from 4.8.139 to 4.8.141 (#8535)
  Bump archunit-junit5-api from 0.22.0 to 0.23.1 (#8536)
…updateCiteprocAlpha4

* 'updateCiteprocAlpha4' of github.com:JabRef/jabref:
  Fix logger
  Fix more checkstyle
  Fix checkstyle
@Siedlerchr
Copy link
Member Author

The problem is that .filter(style -> {
try {
return CSL.canFormatBibliographies(style);
} catch (IOException e) {
LOGGER.warn("Cannot parse CSL style {}", style, e);
return false;
}
})
this throws always a warning because of the style path/URI not found in jpackage build. Maybe because a modularity thing?

* upstream/main:
  Update RemoteSetupTest.java, adding eq() function from mockito (#8561)
  readd encoding after merge
  Open office refactor finalization (formerly OObranch J cleanup) (#7795)
  Revert "Refine documentation (#8551)" (#8560)
  Refine documentation on logging (#8550)
  Revert "Refine documentation (#8551)" (#8559)
  Refine documentation (#8551)
  New Crowdin updates (#8557)
  New Crowdin updates (#8553)
  Fix missing metadata in BibDatabaseContext (#8556)
  Add encoding detection (and pin export to UTF-8) (#8506)
  Add Missing Fillers/Extractors for Supported Fields and Support Day Conversion (#8531)
  Bump checkstyle from 9.3 to 10.0 (#8544)
  Fix online link detection in entry editor (#8514)
  Add some JavaDoc to Fetchers
  Support two argument form of \abx@aux@cite macro in DefaultAuxParser (#8549)
@Siedlerchr
Copy link
Member Author

Problem is that CSL wants to load the csl style from it's classpath and I think due to being in an unnamed module it cannot find the style by the name.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 13, 2022
@Siedlerchr
Copy link
Member Author

Siedlerchr commented Mar 14, 2022

I simply adopted the method from CSL for checking for the bibliography style tag to be present in the xml and this will skip the CSL style.

* upstream/main:
  Fix medline import due to mising module (#8573)
  Bump jackson-dataformat-yaml from 2.13.1 to 2.13.2 (#8568)
  Update Gradle Wrapper from 7.4 to 7.4.1. (#8565)
  Bump org.eclipse.jgit from 6.0.0.202111291000-r to 6.1.0.202203080745-r (#8569)
  Bump jackson-datatype-jsr310 from 2.13.1 to 2.13.2 (#8570)
  Bump libreoffice from 7.3.0 to 7.3.1 (#8571)
  Bump com.adarshr.test-logger from 3.1.0 to 3.2.0 (#8572)
@calixtus calixtus merged commit 3e359ba into main Mar 14, 2022
@calixtus calixtus deleted the updateCiteprocAlpha4 branch March 14, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while generating citation style "Cannot generate preview"
3 participants