Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #8788 JabRef not showing contents of shared database library #8793

Merged
merged 9 commits into from
May 15, 2022
Merged

Fix for #8788 JabRef not showing contents of shared database library #8793

merged 9 commits into from
May 15, 2022

Conversation

falschgeldkind
Copy link
Contributor

@falschgeldkind falschgeldkind commented May 13, 2022 •
edited
Loading

Fixes: #8788

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

christian.bley added 3 commits May 13, 2022 13:50
Fixes Bug JabRef#8788
2a8e555 
added:org.jabref.logic.shared.DBMSProcessor.partitionAndGetSharedEntries(List<Integer> sharedIDs)
Modified:
org.jabref.logic.shared.DBMSSynchronizer.synchronizeLocalDatabase()
Fixes Bug JabRef#8788
7787acd 
added:org.jabref.logic.shared.DBMSProcessor.partitionAndGetSharedEntries(List<Integer> sharedIDs)
Modified:
org.jabref.logic.shared.DBMSSynchronizer.synchronizeLocalDatabase()

Fixes Bug JabRef#8788

added:org.jabref.logic.shared.DBMSProcessor.partitionAndGetSharedEntries(List<Integer> sharedIDs)
Modified:
org.jabref.logic.shared.DBMSSynchronizer.synchronizeLocalDatabase()
Merge remote-tracking branch 'origin/main' into main
c917fc5 
# Conflicts:
#	src/main/java/org/jabref/logic/shared/DBMSProcessor.java
@falschgeldkind falschgeldkind mentioned this pull request May 13, 2022
Closed
2 tasks
@ThiloteE ThiloteE changed the title Bugfix #8788 Fix for #8788 JabRef not showing contents of shared database library May 13, 2022
@Siedlerchr
Copy link
Member

@falschgeldkind
I fixed the check style issues and used Google Guava's LIsts.partition() method.
I cannot push to your repo, so can you please add a changelog entry to the Changelog.md?

PS: For the next time this is helpful (and better create a branch next time) : https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label May 13, 2022
@koppor
Copy link
Member

koppor commented May 15, 2022

I merge as this fixes the issue.

Nevertheless, @falschgeldkind Could you comment about the "magic number" 500? The latency between the desktop app and the server was too high and thus the connection went into a time out?

@koppor koppor merged commit a90ee23 into JabRef:main May 15, 2022
@Siedlerchr
Copy link
Member

The number of parameters in the in clause was too high. Limit of postgres was hit. See issue for detail

Siedlerchr added a commit to Christina0114/jabref that referenced this pull request May 22, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into testMerger
dc70e88 
* upstream/main: (109 commits)
  Fix right clicking a group and choosing "remove selected entries from this group" leads to error when Bibtex source tab is selected (JabRef#8821)
  Fix single identifier cannot be opened on click (JabRef#8838)
  Add Pubmed/Medline Query Transformer (JabRef#8818)
  adjust and add testcases for FileAnnotationViewModel (JabRef#8830)
  Append config instead of replacing (JabRef#8834)
  Fix eclipse config (JabRef#8835)
  Add Nemo file manager (JabRef#8831)
  Fix missing clear action on pressing esc within the "Filter groups" field (JabRef#8829)
  Update bouncycalse to new base version (JabRef#8827)
  add: add test cases for FileUtil (JabRef#8810)
  Restrict use of standard streams (JabRef#8816)
  updated 8802 (JabRef#8817)
  Bump pascalgn/automerge-action from 0.15.2 to 0.15.3 (JabRef#8803)
  Bump jackson-dataformat-yaml from 2.13.2 to 2.13.3 (JabRef#8804)
  Bump icu4j-charset from 70.1 to 71.1 (JabRef#8805)
  Fix notifications that overlap task bar (JabRef#8775)
  checkstye
  Default path for ssl key store is nested inside "JabRef" directory (JabRef#8796)
  Add log on disk (JabRef#8791)
  Fix for JabRef#8788 JabRef not showing contents of shared database library (JabRef#8793)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr left review comments

Assignees
No one assigned
Labels
shared-database status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jabref not showing contents of shared database library
4 participants
@falschgeldkind @Siedlerchr @koppor @ThiloteE