Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Nemo file manager #8831

Merged
merged 1 commit into from
May 19, 2022
Merged

Add Nemo file manager #8831

merged 1 commit into from
May 19, 2022

Conversation

LyzardKing
Copy link
Collaborator

This should fix #8679 for unconfined packages.
I simply updated nautilus to the proper command (it changed at some point) and added caja and nemo.
We still need a better solution for the snap and/or flatpak, but that is more complex, unless the dbus command mentioned in #8679 is added.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@calixtus calixtus merged commit 4baf2a1 into main May 19, 2022
@calixtus calixtus deleted the file_manager_linux branch May 19, 2022 12:03
@calixtus
Copy link
Member

Thanks for your addition to JabRef!

@ThiloteE ThiloteE mentioned this pull request May 19, 2022
Closed
2 tasks
Siedlerchr added a commit to claell/jabref that referenced this pull request May 21, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into clel-notification-c…
e49bf47 
…lick

* upstream/main:
  Add Pubmed/Medline Query Transformer (JabRef#8818)
  adjust and add testcases for FileAnnotationViewModel (JabRef#8830)
  Append config instead of replacing (JabRef#8834)
  Fix eclipse config (JabRef#8835)
  Add Nemo file manager (JabRef#8831)
  Fix missing clear action on pressing esc within the "Filter groups" field (JabRef#8829)
  Update bouncycalse to new base version (JabRef#8827)
  add: add test cases for FileUtil (JabRef#8810)
  Restrict use of standard streams (JabRef#8816)
  updated 8802 (JabRef#8817)
Siedlerchr added a commit to Christina0114/jabref that referenced this pull request May 22, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into testMerger
dc70e88 
* upstream/main: (109 commits)
  Fix right clicking a group and choosing "remove selected entries from this group" leads to error when Bibtex source tab is selected (JabRef#8821)
  Fix single identifier cannot be opened on click (JabRef#8838)
  Add Pubmed/Medline Query Transformer (JabRef#8818)
  adjust and add testcases for FileAnnotationViewModel (JabRef#8830)
  Append config instead of replacing (JabRef#8834)
  Fix eclipse config (JabRef#8835)
  Add Nemo file manager (JabRef#8831)
  Fix missing clear action on pressing esc within the "Filter groups" field (JabRef#8829)
  Update bouncycalse to new base version (JabRef#8827)
  add: add test cases for FileUtil (JabRef#8810)
  Restrict use of standard streams (JabRef#8816)
  updated 8802 (JabRef#8817)
  Bump pascalgn/automerge-action from 0.15.2 to 0.15.3 (JabRef#8803)
  Bump jackson-dataformat-yaml from 2.13.2 to 2.13.3 (JabRef#8804)
  Bump icu4j-charset from 70.1 to 71.1 (JabRef#8805)
  Fix notifications that overlap task bar (JabRef#8775)
  checkstye
  Default path for ssl key store is nested inside "JabRef" directory (JabRef#8796)
  Add log on disk (JabRef#8791)
  Fix for JabRef#8788 JabRef not showing contents of shared database library (JabRef#8793)
  ...
Siedlerchr added a commit to josepylee/jabref that referenced this pull request May 22, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into test-for-citationstyle
2c2a521 
* upstream/main:
  Fix right clicking a group and choosing "remove selected entries from this group" leads to error when Bibtex source tab is selected (JabRef#8821)
  Fix single identifier cannot be opened on click (JabRef#8838)
  Add Pubmed/Medline Query Transformer (JabRef#8818)
  adjust and add testcases for FileAnnotationViewModel (JabRef#8830)
  Append config instead of replacing (JabRef#8834)
  Fix eclipse config (JabRef#8835)
  Add Nemo file manager (JabRef#8831)
  Fix missing clear action on pressing esc within the "Filter groups" field (JabRef#8829)
Siedlerchr added a commit to fly-ing-fish/jabref that referenced this pull request May 22, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into decode-DOI-contains…
51b77ba 
…-masked-characters#8787

* upstream/main:
  Add: Add test cases for non-default styles in CitationStyleTest (JabRef#8828)
  Open event log when clicking on collapsed notification (JabRef#8837)
  Fix right clicking a group and choosing "remove selected entries from this group" leads to error when Bibtex source tab is selected (JabRef#8821)
  Fix single identifier cannot be opened on click (JabRef#8838)
  Add Pubmed/Medline Query Transformer (JabRef#8818)
  adjust and add testcases for FileAnnotationViewModel (JabRef#8830)
  Append config instead of replacing (JabRef#8834)
  Fix eclipse config (JabRef#8835)
  Add Nemo file manager (JabRef#8831)
  Fix missing clear action on pressing esc within the "Filter groups" field (JabRef#8829)
  Update bouncycalse to new base version (JabRef#8827)
  add: add test cases for FileUtil (JabRef#8810)
  Restrict use of standard streams (JabRef#8816)
Siedlerchr added a commit that referenced this pull request May 26, 2022
@Siedlerchr @ThiloteE
Fix linux file opening by using Process Builder
9b2640c 
Fixes #8831


Co-authored-by: ThiloteE <thilo.ertel@posteo.de>
@Siedlerchr Siedlerchr mentioned this pull request May 26, 2022
Merged
6 tasks
Siedlerchr added a commit that referenced this pull request Jun 5, 2022
@Siedlerchr @ThiloteE @btut
Fix linux file opening by using Process Builder (#8853)
35cd5d0 
* Fix linux file opening by using Process Builder

Fixes #8831


Co-authored-by: ThiloteE <thilo.ertel@posteo.de>

* checkstyle

* add comment on nemo


Co-authored-by: ThiloteE <thilo.ertel@posteo.de>

* Refactor terminal opening as well

Co-authored-by: ThiloteE <thilo.ertel@posteo.de>

* Split ProcessBuilder arguments into Array

Co-authored-by: Siedlerchr siedlerkiller@gmail.com

* Refactor passing of dialog servie
Set directory for terminal

* fix checkstyle

* checkstyle

* remove blank line

* add missing  l10n

* add changelog

Co-authored-by: ThiloteE <thilo.ertel@posteo.de>
Co-authored-by: Benedikt Tutzer <btut@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixtus calixtus calixtus approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
external files os: linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"open directory" for attached file does not work
4 participants
@LyzardKing @calixtus @Siedlerchr @ThiloteE