Improve Automatic Field Editor Dialog #8973

HoussemNasri · 2022-07-13T00:00:57Z

Fixes #8970
Closes #8971
Follow-up to #8892

Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

This reverts commit d71f93a.

- Fixes #8970

Why? I argue the word content can be understood more easily than value. The word "value" can be attached to many things e.g. also to field names. The word "content" on the other hand means a value is within something and therefore in this specific context would be more specific. Co-authored-by: ThiloteE <thilo.ertel@posteo.de>

Co-authored-by: ThiloteE <thilo.ertel@posteo.de>

src/main/java/org/jabref/model/strings/StringUtil.java

...abref/gui/edit/automaticfiededitor/copyormovecontent/CopyOrMoveFieldContentTabViewModel.java

Siedlerchr · 2022-07-24T18:27:28Z

src/main/java/org/jabref/model/strings/StringUtil.java

@@ -758,7 +758,7 @@ public static String quoteStringIfSpaceIsContained(String string) {
     * @param s The string to check
     * @return {@code True} if the given string does contain at least one whitespace character, {@code False} otherwise
     * */
-    public static boolean containsAnyWhitespaceCharacters(String s) {
-        return s.matches(".*\s.*");
+    public static boolean containsWhitespace(String s) {


You now need to adapt the failing architecture test to the new size of the StringUtil class.
PS: I wasn't aware of the String.chars method, that's neat

Increased it to 765

calixtus · 2022-07-27T18:22:22Z

There were no issues fixed since the last minor release but issues, that were introduced by #8892, so this PR should not have an entry in the changelog.

Siedlerchr · 2022-07-28T16:48:58Z

In general this looks good to me so far. I only don't like the EventBus introduction here. It's kind of deprecated and should be avoided if not absolutely necessary.

Why not have an observable count in the ViewModel that you can subscribe to in the tab? We use a similar approach for updating the search results. It's a simple IntegerProperty that is in the stateManager

HoussemNasri · 2022-07-28T20:26:31Z

I had no idea that using event bus is deprecated. It's actually one of my favourite bits of our architecture. Using an observable count could be a solution, but what if two consecutive actions affect the same number of entries, causing the count to fire only once?

Siedlerchr · 2022-07-28T20:34:10Z

I would go with observables. Well, if the same number happens you would need to set it to zero before or so before firing the second one.
Regarding the EventBus, there are several reasons:
https://guava.dev/releases/snapshot-jre/api/docs/com/google/common/eventbus/EventBus.html

calixtus · 2022-07-29T04:59:52Z

EventBus is dead. We were planning to remove it for some time.

Why? Because even their docs recommend against using it https://guava.dev/releases/snapshot-jre/api/docs/com/google/common/eventbus/EventBus.html

Co-authored-by: Christoph <siedlerkiller@gmail.com> Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com> Co-authored-by: ThiloteE <73715071+ThiloteE@users.noreply.github.com> Co-authored-by: Jonatan Asketorp <2598631+k3KAW8Pnf7mkmdSMPHz27@users.noreply.github.com>

Co-authored-by: Christoph <siedlerkiller@gmail.com> Co-authored-by: ThiloteE <73715071+ThiloteE@users.noreply.github.com> Co-authored-by: Jonatan Asketorp <2598631+k3KAW8Pnf7mkmdSMPHz27@users.noreply.github.com>

* upstream/main: (21 commits) New Crowdin updates (#9016) New Crowdin updates (#9013) try to gather more output from LO exception (#9002) Improve Automatic Field Editor Dialog (#8973) Update BST VM to Antlr4 (#8934) Support biblatex apa citation for legal entry types (#8966) Bump junit-jupiter from 5.8.2 to 5.9.0 (#9012) Bump lucene-core from 9.2.0 to 9.3.0 (#9009) Bump checkstyle from 10.3.1 to 10.3.2 (#9006) Bump appleboy/ssh-action from 0.1.4 to 0.1.5 (#9005) New translations JabRef_en.properties (Spanish) (#9003) Squashed 'buildres/csl/csl-locales/' changes from 55459cd79f..e637746677 Squashed 'buildres/csl/csl-styles/' changes from 3d3573c..c750b6e Autosave folder and checkbox is remembered (#9000) New Crowdin updates (#8999) Sync group view mode and main table (#8993) Bump unoloader from 7.3.4 to 7.3.5 (#8996) Bump libreoffice from 7.3.4 to 7.3.5 (#8997) Bump java-diff-utils from 4.11 to 4.12 (#8998) Fix external group metadata changes are not merged (#8994) ...

* upstream/main: (39 commits) New Crowdin updates (#9016) New Crowdin updates (#9013) try to gather more output from LO exception (#9002) Improve Automatic Field Editor Dialog (#8973) Update BST VM to Antlr4 (#8934) Support biblatex apa citation for legal entry types (#8966) Bump junit-jupiter from 5.8.2 to 5.9.0 (#9012) Bump lucene-core from 9.2.0 to 9.3.0 (#9009) Bump checkstyle from 10.3.1 to 10.3.2 (#9006) Bump appleboy/ssh-action from 0.1.4 to 0.1.5 (#9005) New translations JabRef_en.properties (Spanish) (#9003) Squashed 'buildres/csl/csl-locales/' changes from 55459cd79f..e637746677 Squashed 'buildres/csl/csl-styles/' changes from 3d3573c..c750b6e Autosave folder and checkbox is remembered (#9000) New Crowdin updates (#8999) Sync group view mode and main table (#8993) Bump unoloader from 7.3.4 to 7.3.5 (#8996) Bump libreoffice from 7.3.4 to 7.3.5 (#8997) Bump java-diff-utils from 4.11 to 4.12 (#8998) Fix external group metadata changes are not merged (#8994) ...

…failure-dialog * upstream/main: (31 commits) Snapcraft and issue template Show development information\n\n+semver: minor Release v5.7 New Crowdin updates (JabRef#9030) New Crowdin updates (JabRef#9029) [Bot] Update CSL styles (JabRef#9027) Add missing translations for AutomaticFieldEditor (JabRef#9028) [Bot] Update Journal abbrev list (JabRef#9026) Rating in main table (JabRef#9023) New Crowdin updates (JabRef#9024) New Crowdin updates (JabRef#9016) New Crowdin updates (JabRef#9013) try to gather more output from LO exception (JabRef#9002) Improve Automatic Field Editor Dialog (JabRef#8973) Update BST VM to Antlr4 (JabRef#8934) Support biblatex apa citation for legal entry types (JabRef#8966) Bump junit-jupiter from 5.8.2 to 5.9.0 (JabRef#9012) Bump lucene-core from 9.2.0 to 9.3.0 (JabRef#9009) Bump checkstyle from 10.3.1 to 10.3.2 (JabRef#9006) Bump appleboy/ssh-action from 0.1.4 to 0.1.5 (JabRef#9005) ...

* upstream/main: (185 commits) Snapcraft and issue template Show development information\n\n+semver: minor Release v5.7 New Crowdin updates (#9030) New Crowdin updates (#9029) [Bot] Update CSL styles (#9027) Add missing translations for AutomaticFieldEditor (#9028) [Bot] Update Journal abbrev list (#9026) Rating in main table (#9023) New Crowdin updates (#9024) New Crowdin updates (#9016) New Crowdin updates (#9013) try to gather more output from LO exception (#9002) Improve Automatic Field Editor Dialog (#8973) Update BST VM to Antlr4 (#8934) Support biblatex apa citation for legal entry types (#8966) Bump junit-jupiter from 5.8.2 to 5.9.0 (#9012) Bump lucene-core from 9.2.0 to 9.3.0 (#9009) Bump checkstyle from 10.3.1 to 10.3.2 (#9006) Bump appleboy/ssh-action from 0.1.4 to 0.1.5 (#9005) ...

…rg.jsoup-jsoup-1.15.2 * upstream/main: (34 commits) Refactor of DOI import failure dialog, import format reader and clipboard manager (#8839) Snapcraft and issue template Show development information\n\n+semver: minor Release v5.7 New Crowdin updates (#9030) New Crowdin updates (#9029) [Bot] Update CSL styles (#9027) Add missing translations for AutomaticFieldEditor (#9028) [Bot] Update Journal abbrev list (#9026) Rating in main table (#9023) New Crowdin updates (#9024) New Crowdin updates (#9016) New Crowdin updates (#9013) try to gather more output from LO exception (#9002) Improve Automatic Field Editor Dialog (#8973) Update BST VM to Antlr4 (#8934) Support biblatex apa citation for legal entry types (#8966) Bump junit-jupiter from 5.8.2 to 5.9.0 (#9012) Bump lucene-core from 9.2.0 to 9.3.0 (#9009) Bump checkstyle from 10.3.1 to 10.3.2 (#9006) ...

HoussemNasri and others added 27 commits March 24, 2022 01:47

Update README.md

376760c

Merge branch 'JabRef:main' into main

d898da1

Merge branch 'JabRef:main' into main

752954b

Merge branch 'JabRef:main' into main

41b499f

Merge branch 'JabRef:main' into main

a63045f

Merge branch 'JabRef:main' into main

0901768

Merge remote-tracking branch 'origin/main' into main

5874b4e

Fix Readme

3c3fb02

Merge branch 'JabRef:main' into main

81815fa

Merge branch 'JabRef:main' into main

18d95c2

Merge branch 'JabRef:main' into main

0e08af3

Merge branch 'JabRef:main' into main

2bb0b6c

Commit

d71f93a

Merge branch 'JabRef:main' into main

57005ce

Update README.md

fffc86c

Merge remote-tracking branch 'origin/main' into main

4f480ba

Merge branch 'JabRef:main' into main

63e09ba

Merge remote-tracking branch 'origin/main' into main

365e968

Revert "Commit"

033b9a2

This reverts commit d71f93a.

Don't copy field value if it doesn't exist

1303d3c

- Fixes #8970

Refactor TwoFields tab to make it easier to test

a4b5e3e

Test TwoFieldsViewModel

fd1006e

Add more tests for TwoFieldsViewModel

2a1a298

Rename dialog's 'Revert' button to 'Cancel'

a8adb0b

Make field ComboBox editable

675ed00

Co-authored-by: ThiloteE <thilo.ertel@posteo.de>

Update ComboBox field list when a new field is added

2bbb097

ThiloteE added the automatic-field-editor label Jul 13, 2022

HoussemNasri added 2 commits July 13, 2022 14:48

Rename "Overwrite Non empty fields" to "Overwrite field content"

ec75377

Cancel changes when the dialog is closed using the X button

72e9287

ThiloteE added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jul 23, 2022

Siedlerchr reviewed Jul 23, 2022

View reviewed changes

src/main/java/org/jabref/model/strings/StringUtil.java Outdated Show resolved Hide resolved

Siedlerchr reviewed Jul 23, 2022

View reviewed changes

...abref/gui/edit/automaticfiededitor/copyormovecontent/CopyOrMoveFieldContentTabViewModel.java Outdated Show resolved Hide resolved

HoussemNasri added 2 commits July 24, 2022 19:11

Update 'containsWhitespace' implementation

9016c1a

Test containsWhitespace

edc9f3e

Siedlerchr reviewed Jul 24, 2022

View reviewed changes

Increase StringUtil maximum line count to 765

f80232a

calixtus requested a review from Siedlerchr July 27, 2022 18:22

Siedlerchr approved these changes Jul 28, 2022

View reviewed changes

HoussemNasri added 5 commits July 29, 2022 14:37

Stop using event bus in EditFieldContentTabView

96c7ea8

Why? Because even their docs recommend against using it https://guava.dev/releases/snapshot-jre/api/docs/com/google/common/eventbus/EventBus.html

Stop using event bus in the other tabs

e925826

Delete AutomaticFieldEditorEvent.java

d89f691

Minimize number of constructor arguments

1c9f063

Update tests

e9a7716

calixtus approved these changes Aug 1, 2022

View reviewed changes

koppor and others added 3 commits August 1, 2022 20:51

Convert to ParameterizedTests

f37c5f8

Co-authored-by: Christoph <siedlerkiller@gmail.com> Co-authored-by: ThiloteE <73715071+ThiloteE@users.noreply.github.com> Co-authored-by: Jonatan Asketorp <2598631+k3KAW8Pnf7mkmdSMPHz27@users.noreply.github.com>

koppor merged commit 0d82506 into JabRef:main Aug 1, 2022

HoussemNasri deleted the improve-auto-field-editor branch September 13, 2022 06:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve Automatic Field Editor Dialog #8973

Improve Automatic Field Editor Dialog #8973

HoussemNasri commented Jul 13, 2022 •

edited

Loading

Siedlerchr Jul 24, 2022

HoussemNasri Jul 24, 2022

calixtus commented Jul 27, 2022 •

edited by HoussemNasri

Loading

Siedlerchr commented Jul 28, 2022

HoussemNasri commented Jul 28, 2022

Siedlerchr commented Jul 28, 2022

calixtus commented Jul 29, 2022

Improve Automatic Field Editor Dialog #8973

Improve Automatic Field Editor Dialog #8973

Conversation

HoussemNasri commented Jul 13, 2022 • edited Loading

Siedlerchr Jul 24, 2022

Choose a reason for hiding this comment

HoussemNasri Jul 24, 2022

Choose a reason for hiding this comment

calixtus commented Jul 27, 2022 • edited by HoussemNasri Loading

Siedlerchr commented Jul 28, 2022

HoussemNasri commented Jul 28, 2022

Siedlerchr commented Jul 28, 2022

calixtus commented Jul 29, 2022

HoussemNasri commented Jul 13, 2022 •

edited

Loading

calixtus commented Jul 27, 2022 •

edited by HoussemNasri

Loading