Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rating in main table #9023

Merged
merged 9 commits into from
Aug 4, 2022
Merged

Rating in main table #9023

merged 9 commits into from
Aug 4, 2022

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Aug 3, 2022 •
edited
Loading

Fixes #5842

Improves rating column to show even when no rating is presented.
Changes symbol from colorful standard controlsfx star to more serious monochrome one.

grafik

grafik

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@calixtus calixtus added type: enhancement ui status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers maintable labels Aug 3, 2022
btut
btut approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@btut btut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not try this out, but code and screenshots look good!

@Siedlerchr
Copy link
Member

grafik

Can you take a look at the contex menu as well?

@calixtus
Copy link
Member Author

calixtus commented Aug 4, 2022

About context menu: seems the right click to select the table row is not passed through the rating control, but for the context menu it is. Very strange.

@calixtus
Copy link
Member Author

calixtus commented Aug 4, 2022

Fixed it.

@Siedlerchr
Copy link
Member

Siedlerchr commented Aug 4, 2022 •
edited
Loading

Looks like this now, didn't we have the number of stars in front of it back then? e..g ** set rank to two
grafik

@calixtus
Copy link
Member Author

calixtus commented Aug 4, 2022 via email •
edited
Loading

@koppor koppor merged commit 9a42bea into JabRef:main Aug 4, 2022
@koppor koppor deleted the fix-5842 branch August 4, 2022 19:49
Siedlerchr added a commit to zkl-ai/jabref that referenced this pull request Aug 5, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into improve-DOI-import-…
d26e288 
…failure-dialog

* upstream/main: (31 commits)
  Snapcraft and issue template
  Show development information\n\n+semver: minor
  Release v5.7
  New Crowdin updates (JabRef#9030)
  New Crowdin updates (JabRef#9029)
  [Bot] Update CSL styles (JabRef#9027)
  Add missing translations for AutomaticFieldEditor (JabRef#9028)
  [Bot] Update Journal abbrev list (JabRef#9026)
  Rating in main table (JabRef#9023)
  New Crowdin updates (JabRef#9024)
  New Crowdin updates (JabRef#9016)
  New Crowdin updates (JabRef#9013)
  try to gather more output from LO exception (JabRef#9002)
  Improve Automatic Field Editor Dialog (JabRef#8973)
  Update BST VM to Antlr4 (JabRef#8934)
  Support biblatex apa citation for legal entry types (JabRef#8966)
  Bump junit-jupiter from 5.8.2 to 5.9.0 (JabRef#9012)
  Bump lucene-core from 9.2.0 to 9.3.0 (JabRef#9009)
  Bump checkstyle from 10.3.1 to 10.3.2 (JabRef#9006)
  Bump appleboy/ssh-action from 0.1.4 to 0.1.5 (JabRef#9005)
  ...
Siedlerchr added a commit that referenced this pull request Aug 6, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-8372
e7374f9 
* upstream/main: (185 commits)
  Snapcraft and issue template
  Show development information\n\n+semver: minor
  Release v5.7
  New Crowdin updates (#9030)
  New Crowdin updates (#9029)
  [Bot] Update CSL styles (#9027)
  Add missing translations for AutomaticFieldEditor (#9028)
  [Bot] Update Journal abbrev list (#9026)
  Rating in main table (#9023)
  New Crowdin updates (#9024)
  New Crowdin updates (#9016)
  New Crowdin updates (#9013)
  try to gather more output from LO exception (#9002)
  Improve Automatic Field Editor Dialog (#8973)
  Update BST VM to Antlr4 (#8934)
  Support biblatex apa citation for legal entry types (#8966)
  Bump junit-jupiter from 5.8.2 to 5.9.0 (#9012)
  Bump lucene-core from 9.2.0 to 9.3.0 (#9009)
  Bump checkstyle from 10.3.1 to 10.3.2 (#9006)
  Bump appleboy/ssh-action from 0.1.4 to 0.1.5 (#9005)
  ...
Siedlerchr added a commit that referenced this pull request Aug 6, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into dependabot/gradle/o…
966d87c 
…rg.jsoup-jsoup-1.15.2

* upstream/main: (34 commits)
  Refactor of DOI import failure dialog, import format reader and clipboard manager (#8839)
  Snapcraft and issue template
  Show development information\n\n+semver: minor
  Release v5.7
  New Crowdin updates (#9030)
  New Crowdin updates (#9029)
  [Bot] Update CSL styles (#9027)
  Add missing translations for AutomaticFieldEditor (#9028)
  [Bot] Update Journal abbrev list (#9026)
  Rating in main table (#9023)
  New Crowdin updates (#9024)
  New Crowdin updates (#9016)
  New Crowdin updates (#9013)
  try to gather more output from LO exception (#9002)
  Improve Automatic Field Editor Dialog (#8973)
  Update BST VM to Antlr4 (#8934)
  Support biblatex apa citation for legal entry types (#8966)
  Bump junit-jupiter from 5.8.2 to 5.9.0 (#9012)
  Bump lucene-core from 9.2.0 to 9.3.0 (#9009)
  Bump checkstyle from 10.3.1 to 10.3.2 (#9006)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btut btut btut approved these changes

@koppor koppor koppor approved these changes

Assignees
No one assigned
Labels
maintable status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers type: enhancement ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Ranking column feature in main table
4 participants
@calixtus @Siedlerchr @koppor @btut