Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the color of found text from red to high contrast #9315

Merged
merged 8 commits into from
Oct 28, 2022
Merged

Changed the color of found text from red to high contrast #9315

merged 8 commits into from
Oct 28, 2022

Conversation

u7232539
Copy link
Contributor

Fixes koppor#552.

This issue is about changing the text color from red to green to avoid misunderstanding in the search.

Before:
Screenshot (46)

The text color of the search was red, which may make users think there was an error in the search.

After:
Screenshot (48)

Highlighted the search text in green color to avoid misunderstanding.
Increased the font size and weight for readability.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

I would like to know what you think about the fix. Any comments would be appreciated.

@u7232539 u7232539 mentioned this pull request Oct 27, 2022
Merged
6 tasks
@ThiloteE
Copy link
Member

Please check readability and provide screenshots for dark mode.

Please use a complementary colour scheme for the fix to create strong contrast. See here: https://en.wikipedia.org/wiki/Complementary_colors

But keep in mind, there are people that have a hard time distinguishing colours: impaired colour vision "Red–green color blindness is the most common form, followed by blue–yellow color blindness and total color blindness.[2]".

@u7232539
Copy link
Contributor Author

Adopted high-contrast colors for text.
Avoided the combination of red-green and blue-yellow.
The background color is yellow (#ffff00) and the font color is purple (#7800A9).

In light theme:
Screenshot (56)

In dark theme:
Screenshot (57)

@ThiloteE
Copy link
Member

Thank you, looking good!

@Siedlerchr
Copy link
Member

Can you please adjust the changelog then (and it seems your latest changes are not yet pushed?)

@u7232539
Copy link
Contributor Author

Sorry about that, I just pushed the latest changes.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 28, 2022
@Siedlerchr Siedlerchr changed the title Changed the color of found text from red to green Changed the color of found text from red to high contrast Oct 28, 2022
@ThiloteE ThiloteE self-requested a review October 28, 2022 16:22
@ThiloteE ThiloteE merged commit 2404578 into JabRef:main Oct 28, 2022
Siedlerchr added a commit to tomazari/jabref that referenced this pull request Nov 1, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into ISBN-fetcher-for-bo…
3009ed1 
…ok-info.com-JabRef#9145

* upstream/main:
  New Crowdin updates (JabRef#9333)
  Refresh example styles
  Squashed 'buildres/csl/csl-styles/' changes from 4eee79a..13fd98e
  Bump unirest-java from 3.13.11 to 3.13.12 (JabRef#9330)
  Bump checkstyle from 10.3.4 to 10.4 (JabRef#9331)
  Bump gittools/actions from 0.9.14 to 0.9.15 (JabRef#9332)
  Group context menu presents relevant options depending on number of subgroups (JabRef#9286)
  Removed BibTeX file type and included HTML and Markdown types (JabRef#9318)
  Fix issue: Auto-linking files with safe character replacements JabRef#9267 (JabRef#9316)
  Fix for issue 8806: Button highlights doesn't respect rounded corners (JabRef#9320)
  New Crowdin updates (JabRef#9324)
  Update CHANGELOG.md
  Try to relocate listener binding (JabRef#9238)
  Changed the messages after importing unlinked local files to past passive tense. (JabRef#9308)
  Changed the color of found text from red to high contrast  (JabRef#9315)

# Conflicts:
#	CHANGELOG.md
Siedlerchr added a commit to DavidOWade/jabref that referenced this pull request Nov 3, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into DavidOWade/main
f584ea3 
* upstream/main: (30 commits)
  New translations JabRef_en.properties (German) (JabRef#9336)
  Fix Abbreviation for Escaped Ampersand (JabRef#9288)
  Fix font size preference not updating in preference dialog 8386 (JabRef#9287)
  New Crowdin updates (JabRef#9333)
  Refresh example styles
  Squashed 'buildres/csl/csl-styles/' changes from 4eee79a..13fd98e
  Bump unirest-java from 3.13.11 to 3.13.12 (JabRef#9330)
  Bump checkstyle from 10.3.4 to 10.4 (JabRef#9331)
  Bump gittools/actions from 0.9.14 to 0.9.15 (JabRef#9332)
  Group context menu presents relevant options depending on number of subgroups (JabRef#9286)
  Removed BibTeX file type and included HTML and Markdown types (JabRef#9318)
  Fix issue: Auto-linking files with safe character replacements JabRef#9267 (JabRef#9316)
  Fix for issue 8806: Button highlights doesn't respect rounded corners (JabRef#9320)
  New Crowdin updates (JabRef#9324)
  Update CHANGELOG.md
  Try to relocate listener binding (JabRef#9238)
  Changed the messages after importing unlinked local files to past passive tense. (JabRef#9308)
  Changed the color of found text from red to high contrast  (JabRef#9315)
  New Crowdin updates (JabRef#9317)
  Add skips for MacOS X build (JabRef#9305)
  ...
Siedlerchr added a commit that referenced this pull request Nov 8, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into 8747-data-field
8464bd6 
* upstream/main:
  New Crowdin updates (#9333)
  Refresh example styles
  Squashed 'buildres/csl/csl-styles/' changes from 4eee79a..13fd98e
  Bump unirest-java from 3.13.11 to 3.13.12 (#9330)
  Bump checkstyle from 10.3.4 to 10.4 (#9331)
  Bump gittools/actions from 0.9.14 to 0.9.15 (#9332)
  Group context menu presents relevant options depending on number of subgroups (#9286)
  Removed BibTeX file type and included HTML and Markdown types (#9318)
  Fix issue: Auto-linking files with safe character replacements #9267 (#9316)
  Fix for issue 8806: Button highlights doesn't respect rounded corners (#9320)
  New Crowdin updates (#9324)
  Update CHANGELOG.md
  Try to relocate listener binding (#9238)
  Changed the messages after importing unlinked local files to past passive tense. (#9308)
  Changed the color of found text from red to high contrast  (#9315)
  New Crowdin updates (#9317)
  Add skips for MacOS X build (#9305)
  New Crowdin updates (#9248)
  Fix for issue 9304 (#9313)

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThiloteE ThiloteE ThiloteE approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
Dark Theme search status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
3 participants
@u7232539 @ThiloteE @Siedlerchr