Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the color of found text from red to green #2

Merged
merged 3 commits into from
Oct 23, 2022

Conversation

u7232539
Copy link
Owner

@u7232539 u7232539 commented Oct 23, 2022

Fixes koppor#552.

This issue is about changing the text color from red to green to avoid misunderstanding in the search.

Before:
Screenshot (46)

The text color of the search was red, which may make users think there was an error in the search.

After:
Screenshot (47)

Highlighted the search text in green color to avoid misunderstanding.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

I would like to know what you think about the fix. Any comments would be appreciated.

@Gpax971
Copy link
Collaborator

Gpax971 commented Oct 23, 2022

Green seems to blend in a little, is it possible to make it bold or change text background?
Also, you should change or censor most of that file path, since it makes it incredibly easy to identify you as a person

@u7232539
Copy link
Owner Author

@Gpax971 Thanks for the comment. I kept the green color and increased the font size and weight for readability.

Latest version:
Screenshot (48)

@Gpax971
Copy link
Collaborator

Gpax971 commented Oct 23, 2022

Looks good now. May want to remove the original picture for privacy though

@u7232539 u7232539 merged commit bd2da5d into main Oct 23, 2022
@u7232539 u7232539 deleted the Change-found-text-color branch October 23, 2022 07:10
@koppor
Copy link

koppor commented Oct 26, 2022

Would it be possible to submit this PR to https://github.com/JabRef/jabref/pulls?

@u7232539
Copy link
Owner Author

I just submitted the PR. JabRef#9315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants