Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Field name:" from localization - we already have "Field name" #9991

Merged
merged 3 commits into from
Jun 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ BooleanBinding isNoKeywordSelected() {
}

void showInputFieldNameDialog() {
dialogService.showInputDialogAndWait(Localization.lang("Add new field name"), Localization.lang("Field name:"))
dialogService.showInputDialogAndWait(Localization.lang("Add new field name"), Localization.lang("Field name"))
.map(FieldFactory::parseField)
.ifPresent(this::addFieldIfUnique);
}
Expand Down
19 changes: 8 additions & 11 deletions src/main/resources/l10n/JabRef_en.properties
Original file line number Diff line number Diff line change
Expand Up @@ -335,12 +335,18 @@ External\ programs=External programs
Failed\ to\ import\ by\ ID=Failed to import by ID

Field=Field

field=field

Field\ name=Field name

Field\ names=Field names
Field\ names\ are\ not\ allowed\ to\ contain\ white\ spaces\ or\ certain\ characters\ (%0).=Field names are not allowed to contain white spaces or certain characters (%0).
New\ field\ name=New field name
Add\ new\ field\ name=Add new field name
Field\ name\ \"%0\"\ already\ exists=Field name "%0" already exists
No\ field\ name\ selected\!=No field name selected!
Remove\ field\ name=Remove field name
Are\ you\ sure\ you\ want\ to\ remove\ field\ name\:\ \"%0\"?=Are you sure you want to remove field name: "%0"?
Manage\ field\ names\ &\ content=Manage field names & content

Field\ to\ group\ by=Field to group by

Expand Down Expand Up @@ -1955,12 +1961,6 @@ Select\ the\ entries\ to\ be\ imported\:=Select the entries to be imported\:
Add\ new\ String=Add new String
Must\ not\ be\ empty\!=Must not be empty\!
Open\ Help\ page=Open Help page
Add\ new\ field\ name=Add new field name
Field\ name\:=Field name:
Field\ name\ \"%0\"\ already\ exists=Field name "%0" already exists
No\ field\ name\ selected\!=No field name selected!
Remove\ field\ name=Remove field name
Are\ you\ sure\ you\ want\ to\ remove\ field\ name\:\ \"%0\"?=Are you sure you want to remove field name: "%0"?
Add\ new\ keyword=Add new keyword
Keyword\:=Keyword:
Keyword\ \"%0\"\ already\ exists=Keyword "%0" already exists
Expand All @@ -1971,7 +1971,6 @@ Reset\ to\ default=Reset to default
String\ constants=String constants
Export\ all\ entries=Export all entries
Generate\ citation\ keys=Generate citation keys
Manage\ field\ names\ &\ content=Manage field names & content
New\ library=New library
OpenOffice/LibreOffice=OpenOffice/LibreOffice
Open\ document\ viewer=Open document viewer
Expand Down Expand Up @@ -2380,7 +2379,6 @@ File\ '%1'\ is\ a\ duplicate\ of\ '%0'.\ Keeping\ both\ due\ to\ deletion\ error
Enable\ field\ formatters=Enable field formatters
Entry\ Type=Entry Type
Entry\ types=Entry types
Field\ names=Field names
Others=Others
Recommended=Recommended

Expand Down Expand Up @@ -2469,7 +2467,6 @@ Clear\ field\ content=Clear field content
Set\ or\ append\ content=Set or append content
Edit\ field\ content\ for\ selected\ entries=Edit field content for selected entries
Rename=Rename
New\ field\ name=New field name
Copy\ content=Copy content
Move\ content=Move content
Swap\ content=Swap content
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ private void removeKeyword(Field field, String keyword) {

private void addField(Field field) {
when(dialogService.showInputDialogAndWait(
Localization.lang("Add new field name"), Localization.lang("Field name:")))
Localization.lang("Add new field name"), Localization.lang("Field name")))
.thenReturn(Optional.of(field.getDisplayName()));

viewModel.showInputFieldNameDialog();
Expand Down