Remove "Field name:" from localization - we already have "Field name" #9991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koppor
added
the
status: ready-for-review
Siedlerchr
reviewed
Jun 8, 2023
| @@ -102,7 +102,7 @@ BooleanBinding isNoKeywordSelected() { | |||
| } | |||
|
|
|||
| void showInputFieldNameDialog() { | |||
| dialogService.showInputDialogAndWait(Localization.lang("Add new field name"), Localization.lang("Field name:")) | |||
| dialogService.showInputDialogAndWait(Localization.lang("Add new field name"), Localization.lang("Field name") + ":") | |||
There was a problem hiding this comment.
Please don't do this! you never know other non latin languages handle this!
There was a problem hiding this comment.
A) The existing code already has these things
B) all translations have the : at the end - or omit it.
Example:
I think, all of them are wrong ^^
Example for this:
The : should be removed as the label formatting itself should indicate that it is a label - and not the :
Siedlerchr
added a commit
that referenced
this pull request
Jan 1, 2024
* upstream/main: (68 commits) Fix issue 9863 - Change Tab selection order (#9907) New Crowdin updates (#9994) Enable editing typo with double clicking on field name in custom entry type (#9977) Remove "Field name:" from localization - we already have "Field name" (#9991) Changed database to catalog in org.jabref.gui.slr and org.jabref.logic.crawler (#9989) Use environment variables for hostname detection (#9910) Add cleanup activity for URL field (#9970) Fix freezing when fetching IBSN and no results are found (#9987) Make Group(Node)TreeViewModel more OO (#9978) Fix container for group item count still visible if display count is off (#9980) Fix paste of BibTeX data (#9985) Bring back SimplifyBoolean* and UnnecessaryParantheses (and refine guide) (#9981) Add new menu entry to remove braces from selection, aka unprotect it. (#9968) User specific comment (#9727) Bump org.openrewrite.recipe:rewrite-recipe-bom from 1.19.3 to 2.0.0 (#9975) Fix typos Remove non-needed link Fix typos Enable RemoveJavaDocAuthorTag (#9973) Bump com.fasterxml.jackson.datatype:jackson-datatype-jsr310 (#9974) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered by https://github.com/JabRef/jabref/pull/9989/files#diff-f1bccc4fe4e0595584a0e84d950cb03c36f9246fa7f5799a526b1d34d1c434be
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)