Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Workflows security hardening #5322

Merged
merged 2 commits into from
Oct 24, 2022
Merged

GitHub Workflows security hardening #5322

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f556c1
Update release.yml
sashashura Aug 28, 2022
45ab14c
Update release.yml
sashashura Aug 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,15 @@ on:
branches:
- master

permissions:
contents: read

jobs:
release:
permissions:
# for changesets/action
contents: write
pull-requests: write
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sashashura this workflow has only one job, couldn't we use only one permissions definition?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is optional, but the reasoning was I wanted to have a safe global default in case someone later adds more jobs. Let me know if you want me to put everything at the global level.

name: Release
runs-on: ubuntu-latest
steps:
Expand Down