This repository has been archived by the owner on Jun 3, 2022. It is now read-only.
feat(indexer): deprecated SetOracleDataIntervalIndexer Indexer & API #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defichain-bot
added
area/module-api
area/module-indexer
area/module-model
area/whale-api-client
kind/chore
|
Code Climate has analyzed commit 3553ce3 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #749 +/- ##
==========================================
- Coverage 92.68% 92.28% -0.40%
==========================================
Files 115 113 -2
Lines 2993 2904 -89
Branches 372 363 -9
==========================================
- Hits 2774 2680 -94
- Misses 210 215 +5
Partials 9 9
Continue to review full report at Codecov.
|
fuxingloh
requested review from
canonbrother,
ivan-zynesis,
jingyi2811,
monstrobishi and
thedoublejay
as code owners
canonbrother
approved these changes
Feb 3, 2022
monstrobishi
approved these changes
Feb 3, 2022
fuxingloh
deleted the
fuxingloh/drop-oracle-interval-aggregate-indexer
branch
eli-lim
pushed a commit
to BirthdayResearch/jellyfishsdk
that referenced
this pull request
Mar 28, 2022
…ellyfishSDK/whale#749) * feat(indexer): deprecated SetOracleDataIntervalIndexer Indexer & API * updated deprecation notice with PR url * fix invalid import
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind feature
/kind chore
What this PR does / why we need it:
SetOracleDataIntervalIndexerwhich was introduced in #283 produces a new API available at this endpoint:/:key/feed/interval/:interval. While this provides useful information for data graphing, this API was heavily underutilized as no product integration was built for it yet.Following the footsteps of a recent chore(database): optimization, this PR attempt to remove indexes that aren't heavily used by the DeFiChain ecosystem.
Although we are deprecating this endpoint immediately now in an effort to move fast, the end goal is to move to a more robust indexing system.