This repository has been archived by the owner on Jun 3, 2022. It is now read-only.
feat(indexer): Indexing Oracles Data #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suraj Auwal <siradjiawoual@gmail.com>
Signed-off-by: Suraj Auwal <siradjiawoual@gmail.com>
Signed-off-by: Suraj Auwal <siradjiawoual@gmail.com>
Signed-off-by: Suraj Auwal <siradjiawoual@gmail.com>
defichain-bot
added
kind/feature
|
Code Climate has analyzed commit c69b772 and detected 7 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
joeldavidw
reviewed
Mar 15, 2022
joeldavidw
reviewed
Mar 15, 2022
joeldavidw
reviewed
Mar 15, 2022
nichellekoh
requested review from
fuxingloh,
canonbrother,
jingyi2811,
ivan-zynesis and
thedoublejay
as code owners
Codecov Report
@@ Coverage Diff @@
## main #853 +/- ##
==========================================
+ Coverage 91.87% 92.46% +0.59%
==========================================
Files 125 127 +2
Lines 3469 3675 +206
Branches 435 461 +26
==========================================
+ Hits 3187 3398 +211
+ Misses 272 267 -5
Partials 10 10
Continue to review full report at Codecov.
|
joeldavidw
approved these changes
Mar 16, 2022
fuxingloh
approved these changes
Mar 16, 2022
eli-lim
pushed a commit
to BirthdayResearch/jellyfishsdk
that referenced
this pull request
Mar 28, 2022
* Revert Changes Signed-off-by: Suraj Auwal <siradjiawoual@gmail.com> * Removed package installation files Signed-off-by: Suraj Auwal <siradjiawoual@gmail.com> * package-lock.json Signed-off-by: Suraj Auwal <siradjiawoual@gmail.com> * Removed unrelated changes Signed-off-by: Suraj Auwal <siradjiawoual@gmail.com> * Updated time interval * Modify Oracle Feed Intervals * Update feed intervals to 15 mins for testing * Resolve issue with time bucketing and median time * Added more test asserts for oracles and prices test Co-authored-by: Suraj Auwal <siradjiawoual@gmail.com> Co-authored-by: Joel-David Wong <git@joeldavid.dev>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
Reverted Changes in PR #749
Update time intervals according to oracles feed and requirements - 15 mins, 1 hour, 1 day
Which issue(s) does this PR fixes?:
Fixes #
Additional comments?: