Recognize Checker Framework *declaration* annotations #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are migrating Guava to use these annotations rather than jsr305's @nullable. We can't use the Checker Framework's _@Nullable_ yet because we promise compatibility with Java 7, which doesn't support type annotations. This is related to but distinct from https://youtrack.jetbrains.com/issue/KT-21408, which is about a different jsr305 annotation we use, @ParametersAreNonnullByDefault. I've also updated some docs to mention Kotlin's existing support for the Checker Framework _@NonNull_. NOTE: This commit does not yet run the new tests (though I've found a hacky way to confirm that they will indeed pass). I am unsure how to update files like ForeignAnnotationsTestGenerated.java that say they are generated with org.jetbrains.kotlin.generators.tests.TestsPackageorg.jetbrains.kotlin.generators.tests.TestsPackage (and so testAllFilesPresentInTests is failing for them). Please advise me how to update those files. Thanks.
|
To update |
|
Thanks! I've updated the generated tests. |
|
We have a version of Guava coming out that uses the Checker Framework declaration annotations, so we're eager to see this go in. Let me know if there's anything else I can do to help things along. |
|
Could you please report a separate issue describing your use case, so that we could track it properly, it'd end up in the changelog in the correct place, etc. Thanks! |
|
Thanks. I've filed KT-21982. |
|
And thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are migrating Guava to use these annotations rather than jsr305's
@Nullable.We can't use the Checker Framework's
@Nullableyet because we promise compatibility with Java 7, which doesn't support type annotations.This is related to but distinct from https://youtrack.jetbrains.com/issue/KT-21408, which is about a different jsr305 annotation we use,
@ParametersAreNonnullByDefault.I've also updated some docs to mention Kotlin's existing support for the Checker Framework
@NonNull.NOTE: This commit does not yet run the new tests (though I've found a hacky way to confirm that they will indeed pass). I am unsure how to update files like
ForeignAnnotationsTestGenerated.javathat say they are generated withorg.jetbrains.kotlin.generators.tests.TestsPackageorg.jetbrains.kotlin.generators.tests.TestsPackage(and sotestAllFilesPresentInTestsis failing for them). Please advise me how to update those files. Thanks.