Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize Checker Framework *declaration* annotations #1421

Closed
wants to merge 2 commits into from

Commits on Dec 5, 2017

  1. Recognize Checker Framework declaration annotations.

    We are migrating Guava to use these annotations rather than jsr305's @nullable.
    We can't use the Checker Framework's _@Nullable_ yet because we promise compatibility with Java 7, which doesn't support type annotations.
    This is related to but distinct from https://youtrack.jetbrains.com/issue/KT-21408, which is about a different jsr305 annotation we use, @ParametersAreNonnullByDefault.
    
    I've also updated some docs to mention Kotlin's existing support for the Checker Framework _@NonNull_.
    
    NOTE: This commit does not yet run the new tests (though I've found a hacky way to confirm that they will indeed pass). I am unsure how to update files like ForeignAnnotationsTestGenerated.java that say they are generated with org.jetbrains.kotlin.generators.tests.TestsPackageorg.jetbrains.kotlin.generators.tests.TestsPackage (and so testAllFilesPresentInTests is failing for them). Please advise me how to update those files. Thanks.
    cpovirk committed Dec 5, 2017
    Configuration menu
    Copy the full SHA
    6419dd7 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2017

  1. Update generated tests.

    cpovirk committed Dec 6, 2017
    Configuration menu
    Copy the full SHA
    b6ca911 View commit details
    Browse the repository at this point in the history