Add skip_vendor_specific_container argument option for test_monitoring_critical_processes #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic container will not run in host namespaces
JibinBao
pushed a commit
that referenced
this pull request
Feb 23, 2024
From the ovs doc, if mod-flow is used without --strict, priority is not used in matching. This will cause problem for downstream set_drop when duplicate_nic_upstream is disabled. For example: When set_drop is applied to upstream_nic_flow(#1), mod-flow will match both flow #2 and flow #3 as priority is not used in flow match. So let's enforce strict match for mod-flow. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
JibinBao
pushed a commit
that referenced
this pull request
Jun 14, 2024
From the ovs doc, if mod-flow is used without --strict, priority is not used in matching. This will cause problem for downstream set_drop when duplicate_nic_upstream is disabled. For example: When set_drop is applied to upstream_nic_flow(#1), mod-flow will match both flow #2 and flow #3 as priority is not used in flow match. So let's enforce strict match for mod-flow. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Because monit (the daemon that prints this message) has been deprecated and app. Ext does not use it. So when there is some vendor specific container installed in DUT. After run test_monitoring_critical_processes case, it will raise some error logs like " Process 'wjhd' is not running in namespace 'host'.* ". So we add skip_vendor_specific_container option to skip the specified container check.
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
It is to fix the issue: After run test_monitoring_critical_processes, it will raise some error log like " Process 'wjhd' is not running in namespace 'host'.* ".
How did you do it?
Add one argument option of skip_vendor_specific_container, so we can pass the specified vendor container to the test, and then the check for specified container will be skipped.
How did you verify/test it?
Run tests with follow cmds:
CMD with skip_vendor_specific_container:
py.test process_monitoring/test_critical_process_monitoring.py --inventory "../ansible/inventory, ../ansible/veos" --host-pattern r-liger-02 --module-path ../ansible/library/ --testbed r-liger-02-ptf-any --testbed_file ../ansible/testbed.csv --allow_recover --skip_vendor_specific_container "vendor_container1, vendor_container2"
CMD without skip_vendor_specific_container:
py.test process_monitoring/test_critical_process_monitoring.py --inventory "../ansible/inventory, ../ansible/veos" --host-pattern r-liger-02 --module-path ../ansible/library/ --testbed r-liger-02-ptf-any --testbed_file ../ansible/testbed.csv --allow_recover
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation