Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create yaml test file #64

Merged
merged 6 commits into from
Oct 25, 2022
Merged

Create yaml test file #64

merged 6 commits into from
Oct 25, 2022

Conversation

Tegridy
Copy link
Contributor

@Tegridy Tegridy commented Oct 24, 2022

Fixes #61

JoaoDanielRufino
JoaoDanielRufino requested changes Oct 24, 2022
View reviewed changes
Copy link
Owner

@JoaoDanielRufino JoaoDanielRufino left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Tegridy, you also need to update analyzer_test.go and scanner_test.go.

Please, take a look at PR #54 for example.

JoaoDanielRufino
JoaoDanielRufino requested changes Oct 24, 2022
View reviewed changes
test/fixtures/code_samples/example.yml Outdated
Comment on lines 1 to 26
spring:
config:
import: optional:configserver:http://localhost:8888/
cloud:
vault:
generic:
enabled: true
profile-separator: '/'
default-context: app
jpa:
properties:
hibernate:
dialect: org.hibernate.dialect.PostgreSQLDialect
hibernate:
ddl-auto: validate
application:
name: app-name
liquibase:
change-log: classpath:db/changelog/db.changelog-master.xml
keycloak:
auth-server-url: http://localhost:8080/auth
realm: master
resource: resource-name
server:
port: 0

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a line comment anywhere on this files for tests purpose ?

@JoaoDanielRufino JoaoDanielRufino added the hacktoberfest Hacktoberfest event label Oct 24, 2022
@JoaoDanielRufino JoaoDanielRufino added the hacktoberfest-accepted Hacktoberfest accepted pull request label Oct 25, 2022
JoaoDanielRufino
JoaoDanielRufino approved these changes Oct 25, 2022
View reviewed changes
Copy link
Owner

@JoaoDanielRufino JoaoDanielRufino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@JoaoDanielRufino JoaoDanielRufino merged commit d8238d8 into JoaoDanielRufino:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoaoDanielRufino JoaoDanielRufino JoaoDanielRufino approved these changes

Assignees
No one assigned
Labels
hacktoberfest Hacktoberfest event hacktoberfest-accepted Hacktoberfest accepted pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add YAML code sample for tests
2 participants
@Tegridy @JoaoDanielRufino