forked from musescore/MuseScore
-
-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ENG-85: Improve tuplet rounding error correction
MusicXML exporters tend to have a fixed maximum <divisions> value, meaning more complex tuplets (5's, 7's) have incorrect duration values. These were already handled for tuplets, but sometimes not handled for <backup> elements within or after a tuplet. This commit adds a more thorough system for rounding durations off to more sensible values. In doing so, it unifies the conversion process from <duration> to Fraction (which previously existed almost identically in three separate places) to pass1.calcTicks(). Duplicate of musescore#8766, part 2, needed to resolve merge conflicts
- Loading branch information
1 parent
fe5b928
commit d3b6975
Showing
11 changed files
with
4,674 additions
and
72 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.