[MU3 Backend] ENG-78 fix spanner offsets #8766

iveshenry18 · 2021-07-30T04:11:58Z

Resolves: ENG-78: Crescendo offsets mishandled

Previously, the element was not correctly applied to any
spanners in elements. This commit fixes that and adjusts the
applicable tests accordingly.

This PR also includes the commits from #8742 and #8688.

I signed CLA
I made sure the code in the PR follows the coding rules
I made sure the code compiles on my machine
I made sure there are no unnecessary changes in the code
I made sure the title of the PR reflects the core meaning of the issue you are solving
I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
I made sure the commit message title starts with "fix #424242:" if there is a related issue
I created the test (mtest, vtest, script test) to verify the changes I made

Sometimes pedals are imported that begin or end on segments that have notes on tracks (or staves) other than the track the spanner is on. Previously, this would cause incorrect tick adjustments on "change" type pedals, and it would result in some pedals not being able to compute a start or end element. This commit fixes these issues by considering all tracks of a part when assessing pedal change tick adjustments and when computing start elements.

MusicXML exporters tend to have a fixed maximum <divisions> value, meaning more complex tuplets (5's, 7's) have incorrect duration values. These were already handled for tuplets, but sometimes not handled for <backup> elements within or after a tuplet. This commit adds a more thorough system for rounding durations off to more sensible values. In doing so, it unifies the conversion process from <duration> to Fraction (which previously existed almost identically in three separate places) to pass1.calcTicks().

Previously, the <offset> element was not correctly applied to any spanners in <direction> elements. This commit fixes that and adjusts the applicable tests accordingly.

Sometimes pedals are imported that begin or end on segments that have notes on tracks (or staves) other than the track the spanner is on. Previously, this would cause incorrect tick adjustments on "change" type pedals, and it would result in some pedals not being able to compute a start or end element. This commit fixes these issues by considering all tracks of a part when assessing pedal change tick adjustments and when computing start elements. Duplicate of musescore#8766, part 1

MusicXML exporters tend to have a fixed maximum <divisions> value, meaning more complex tuplets (5's, 7's) have incorrect duration values. These were already handled for tuplets, but sometimes not handled for <backup> elements within or after a tuplet. This commit adds a more thorough system for rounding durations off to more sensible values. In doing so, it unifies the conversion process from <duration> to Fraction (which previously existed almost identically in three separate places) to pass1.calcTicks(). Duplicate of musescore#8766, part 2, needed to resolve merge conflicts

Previously, the <offset> element was not correctly applied to any spanners in <direction> elements. This commit fixes that and adjusts the applicable tests accordingly. Duplicate of musescore#8766, part 3

MusicXML exporters tend to have a fixed maximum <divisions> value, meaning more complex tuplets (5's, 7's) have incorrect duration values. These were already handled for tuplets, but sometimes not handled for <backup> elements within or after a tuplet. This commit adds a more thorough system for rounding durations off to more sensible values. In doing so, it unifies the conversion process from <duration> to Fraction (which previously existed almost identically in three separate places) to pass1.calcTicks(). Duplicate of musescore#8766, part 2, plus resolving a merge conflict with musescore#8282 (resp. 8429, for master) and fixing 2 compiler warnings.

Previously, the <offset> element was not correctly applied to any spanners in <direction> elements. This commit fixes that and adjusts the applicable tests accordingly. Duplicate of musescore#8766, part 3

Jojo-Schmitz mentioned this pull request Jul 30, 2021

[MU3 Issue] MuseScore 3.6.3 or 3.7.0, PRs to be merged and issues to be fixed. #7449

Closed

iveshenry18 added 2 commits July 30, 2021 17:24

iveshenry18 force-pushed the ENG-78-crescendo-offsets branch from 700598e to f0ebcac Compare July 30, 2021 23:57

ENG-78: fix wedges with <offset> values

d22df37

Previously, the <offset> element was not correctly applied to any spanners in <direction> elements. This commit fixes that and adjusts the applicable tests accordingly.

iveshenry18 force-pushed the ENG-78-crescendo-offsets branch from f0ebcac to d22df37 Compare July 31, 2021 00:37

This was referenced Jul 31, 2021

[MU3 Backend] ENG-85: Improve tuplet rounding error correction #8742

Closed

[MU3 Backend] ENG-68: Fix pedal endpoints on other tracks #8688

Closed

oktophonie approved these changes Aug 3, 2021

View reviewed changes

iveshenry18 mentioned this pull request Aug 3, 2021

Musicxml duration 3.x #8282

Closed

8 tasks

vpereverzev approved these changes Aug 5, 2021

View reviewed changes

vpereverzev merged commit 6a740d3 into musescore:3.6.2_backend Aug 5, 2021

Jojo-Schmitz mentioned this pull request Sep 1, 2021

[MU3] Fix GH#7449: Almost everything suitable for 3.6.3 or 3.7.0 #9000

Closed

Jojo-Schmitz mentioned this pull request Mar 1, 2023

Fix GH#7449: Almost everything suitable for 3.6.3 or 3.7.0 Jojo-Schmitz/MuseScore#80

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MU3 Backend] ENG-78 fix spanner offsets #8766

[MU3 Backend] ENG-78 fix spanner offsets #8766

iveshenry18 commented Jul 30, 2021 •

edited

Loading

[MU3 Backend] ENG-78 fix spanner offsets #8766

[MU3 Backend] ENG-78 fix spanner offsets #8766

Conversation

iveshenry18 commented Jul 30, 2021 • edited Loading

iveshenry18 commented Jul 30, 2021 •

edited

Loading