Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parry's TriMeshFlags::FIX_INTERNAL_EDGES to avian's TrimeshFlags #418

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

zhaop
Copy link
Contributor

@zhaop zhaop commented Jul 12, 2024

Objective

  • collision::collider::parry::TrimeshFlag is missing parry's TriMeshFlags::FIX_INTERNAL_EDGES.

Solution

  • This PR copy-pastes the implementation from parry (with 1 << 7 changed to 0b1000_0000 for consistency).

Changelog

  • Added parry's FIX_INTERNAL_EDGES to TrimeshFlags, which fixes some collisions from edges on flat surfaces.

@Jondolf Jondolf added the A-Collision Relates to the broad phase, narrow phase, colliders, or other collision functionality label Jul 12, 2024
@Jondolf Jondolf merged commit 15e92b6 into Jondolf:main Jul 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Collision Relates to the broad phase, narrow phase, colliders, or other collision functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants