Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HierarchyPlugin optional #423

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Conversation

Jondolf
Copy link
Owner

@Jondolf Jondolf commented Jul 13, 2024

Objective

Avian 0.1.0 introduced a regression where HierarchyPlugin and ColliderHierarchyPlugin are needed for colliders to function, as ColliderParent was only inserted by ColliderHierarchyPlugin. Hierarchies shouldn't be necessary.

Solution

Update ColliderParent for colliders that are on the RigidBody entity in the ColliderBackendPlugin, and change panics to warnings when using ColliderHierarchyPlugin without HierarchyPlugin.

@Jondolf Jondolf added C-Regression Behaviour that was working before is now worse or broken bugfix labels Jul 13, 2024
@Jondolf Jondolf merged commit 3425b7a into main Jul 13, 2024
4 checks passed
@Jondolf Jondolf deleted the optional-collider-hierarchy-plugin branch July 13, 2024 17:03
@Jondolf Jondolf added C-Bug Something isn't working and removed bugfix labels Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Bug Something isn't working C-Regression Behaviour that was working before is now worse or broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant