Keep the order of scoped and scopeless nodes in polyfilled browsers. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Scopeless nodes - like declarative-shadow-dom with default slot for merged partial view - were stamped before, scoped nodes - like declarative-shadow-dom with default compositions for apps. That was resulting in non-slotted elements to appear on top instead of bottom (as in browsers with native HTML Imports) Related: https://github.com/Starcounter/KitchenSink/issues/219 Starcounter/starcounter-include#69
tomalec
force-pushed
the
keep-scoped-and-scopeless-order
branch
from
01e6192
to
101e0f6
Compare
warpech
approved these changes
Jan 3, 2018
|
Setting as “Finished” because it is:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Scopeless nodes - like declarative-shadow-dom with default slot for merged partial view - were stamped before, scoped nodes - like declarative-shadow-dom with default compositions for apps.
That was resulting in non-slotted elements to appear on top instead of bottom (as in browsers with native HTML Imports)
Related:
https://github.com/Starcounter/KitchenSink/issues/219
Starcounter/starcounter-include#69