Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⏰ starcounter-include does not work in V1 with browsers other than Chrome #69

Closed
warpech opened this issue Dec 12, 2017 · 2 comments
Closed

⏰ starcounter-include does not work in V1 with browsers other than Chrome #69

warpech opened this issue Dec 12, 2017 · 2 comments
Assignees
@tomalec

Comments

@warpech
Copy link
Contributor

warpech commented Dec 12, 2017

This issue is fixed in polyfill here webcomponents/html-imports#77

Until polyfill accepts the PR, @tomalec will make a workaround in starcounter-include
@warpech warpech changed the title starcounter-include does not work in V1 with browsers other than Chrome ⏰ starcounter-include does not work in V1 with browsers other than Chrome Dec 12, 2017
tomalec added a commit to Juicy/imported-template that referenced this issue Dec 12, 2017
@tomalec
Workaround imported scripts execution,
7938db7 
as in webcomponents/html-imports#77

webcomponents/webcomponentsjs#872
Starcounter/starcounter-include#69
@tomalec tomalec mentioned this issue Dec 13, 2017
Merged
tomalec added a commit that referenced this issue Dec 19, 2017
@tomalec
Use cross-browser version of Juicy/imported-template@3.1.0, adapt tes…
4fbeaf1 
…ts to polyfill caveats

like `class="style-scope starcounter-include"`,
Change `compareHTMLStrings`to actual assertion and make it more verbose.

#69
tomalec added a commit that referenced this issue Dec 19, 2017
@tomalec
Enable CustomElements V1 in Safari.
188f2a7 
Use `sameHTMLString` expectation in custom.html tests
#69
@tomalec tomalec mentioned this issue Dec 20, 2017
Merged
tomalec added a commit that referenced this issue Dec 20, 2017
@tomalec
Let Safari use Shadow DOM v1
7696a42 
#69
tomalec added a commit that referenced this issue Dec 20, 2017
@tomalec
Let Safari use Shadow DOM v1
1077b5b 
#69
tomalec added a commit that referenced this issue Dec 20, 2017
@tomalec
Merge pull request #73 from /issues/69-x-browser-CEv1
b7778aa 
Cross-browser support #69
tomalec added a commit that referenced this issue Dec 30, 2017
@tomalec
Fix the flow, do try to stamp partial on constructor,
020bea9 
do it on `connectedCallback` and partial set,

Allow changing sub-partial's Html property or entire sub-partial via Polymer
Set href in `stampImportedTemplate`, do not set the model in partial setter if the template is already being stamped

Simplify model setting
Rename _compositionChanged to updateComposition

Problems:
 There was a blank page sometimes - #71
 There was a bunch of failing tests - #71, #69,
 The flow was missing many cases. #75
@tomalec tomalec mentioned this issue Dec 30, 2017
Merged
tomalec added a commit to Juicy/imported-template that referenced this issue Jan 3, 2018
@tomalec
Keep the order of scoped and scopeless nodes in polyfilled browsers.
01e6192 
Problem: Scopeless nodes - like declarative-shadow-dom with default slot for merged partial view - were stamped before, scoped nodes - like declarative-shadow-dom with default compositions for apps.
That was resulting in non-slotted elements to appear on top instead of bottom (as in browsers with native HTML Imports)

Related:
https://github.com/Starcounter/KitchenSink/issues/219
Starcounter/starcounter-include#69
@tomalec tomalec mentioned this issue Jan 3, 2018
Merged
tomalec added a commit to Juicy/imported-template that referenced this issue Jan 3, 2018
@tomalec
Keep the order of scoped and scopeless nodes in polyfilled browsers.
101e0f6 
Problem: Scopeless nodes - like declarative-shadow-dom with default slot for merged partial view - were stamped before, scoped nodes - like declarative-shadow-dom with default compositions for apps.
That was resulting in non-slotted elements to appear on top instead of bottom (as in browsers with native HTML Imports)

Related:
https://github.com/Starcounter/KitchenSink/issues/219
Starcounter/starcounter-include#69
tomalec added a commit to Starcounter/StarcounterClientFiles that referenced this issue Jan 3, 2018
@tomalec
Add support for WC polyfilled browsers,
d851cc4 
Update
- Starcounter/starcounter-include@4.1.0
  - Juicy/imported-template@3.1.1
- webcomponents/webcomponentsjs@1.0.22

Starcounter/starcounter-include#69
@tomalec tomalec mentioned this issue Jan 3, 2018
Merged
@tomalec
Copy link
Contributor

tomalec commented Jan 6, 2018

Fixed, and released in 2.4.0.4448 https://github.com/Starcounter/level1/pull/4435

@tomalec tomalec closed this as completed Jan 6, 2018
@warpech
Copy link
Contributor Author

warpech commented Jan 9, 2018

Setting as “Finished” because it is:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomalec tomalec

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomalec @warpech