Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the integration tests #1081

Merged
merged 9 commits into from
Jan 14, 2024
Merged

Fix the integration tests #1081

merged 9 commits into from
Jan 14, 2024

Conversation

DilumAluthge
Copy link
Member

No description provided.

@DilumAluthge
Copy link
Member Author

cc: @ablaom

@ablaom
Copy link
Member

ablaom commented Jan 13, 2024

Thanks for looking further into this. Indeed the flag is now being set and the integration tests are definitely running here. However, my intention with this condition was to rule out testing except for PRs with dev as source. Since the current PR does not have dev as source, I don't want them to run here. So why is my flag nevertheless getting set?

@ablaom
Copy link
Member

ablaom commented Jan 13, 2024

BTW. I forgot that I hard coded the tests to be minimal, for testing the tests, so they only take a few minutes not an hour.

@DilumAluthge
Copy link
Member Author

Seems like there's a bug in the condition.

@ablaom
Copy link
Member

ablaom commented Jan 13, 2024

Mmmm. I literally copied the condition from here where it appears to work.

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fc139f2) 57.89% compared to head (285147e) 57.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1081   +/-   ##
=======================================
  Coverage   57.89%   57.89%           
=======================================
  Files           2        2           
  Lines          38       38           
=======================================
  Hits           22       22           
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DilumAluthge
Copy link
Member Author

@ablaom Looks like it's working now.

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your time @DilumAluthge working this out. Much appreciated. I'll merge this and give it another whirl with a new dev -> master PR.

@ablaom ablaom merged commit 9c31d30 into JuliaAI:dev Jan 14, 2024
2 checks passed
@DilumAluthge DilumAluthge deleted the dpa/fix-integration-ci branch January 14, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants