-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the integration tests #1081
Conversation
cc: @ablaom |
Thanks for looking further into this. Indeed the flag is now being set and the integration tests are definitely running here. However, my intention with this condition was to rule out testing except for PRs with |
BTW. I forgot that I hard coded the tests to be minimal, for testing the tests, so they only take a few minutes not an hour. |
Seems like there's a bug in the condition. |
Mmmm. I literally copied the condition from here where it appears to work. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1081 +/- ##
=======================================
Coverage 57.89% 57.89%
=======================================
Files 2 2
Lines 38 38
=======================================
Hits 22 22
Misses 16 16 ☔ View full report in Codecov by Sentry. |
@ablaom Looks like it's working now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your time @DilumAluthge working this out. Much appreciated. I'll merge this and give it another whirl with a new dev -> master PR.
No description provided.