Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the integration tests #1081

Merged
merged 9 commits into from
Jan 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,18 @@ jobs:
arch:
- x64
steps:
- name: Determine if PR is from a fork
run: |
echo "head_ref is: ${{ github.head_ref }}"
echo "target repository is: ${{ github.repository }}"
echo "head repository is: ${{ github.event.pull_request.head.repo.full_name }}"
- name: Set integration test flag
if: (github.head_ref == 'dev') && (github.repository == github.event.pull_request.head.repo.full_name)
run: |
echo "MLJ_TEST_INTEGRATION=true" >> "${GITHUB_ENV:?}"
- name: Verify the value of the integration test flag
run: |
julia - e '
open("ENV[\"GITHUB_ENV\"]", "a") do io
name = "MLJ_TEST_INTEGRATION"
value = "true"
line = "$(name)=$(value)"
println(io, line)
end'
if: (${{ github.head_ref }} == "dev") && (${{ github.repository }} == ${{ github.event.pull_request.head.repo.full_name }})
echo "MLJ_TEST_INTEGRATION is ${MLJ_TEST_INTEGRATION}"
- uses: actions/checkout@v2
- uses: julia-actions/setup-julia@v1
with:
Expand Down
2 changes: 1 addition & 1 deletion test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ end
@test include("scitypes.jl")
end

if get(ENV, "MLJ_TEST_INTEGRATION", "false") == "true"
if parse(Bool, get(ENV, "MLJ_TEST_INTEGRATION", "false"))
@testset "integration" begin
@test include("integration.jl")
end
Expand Down
Loading