Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable parameter validation by default #30

Merged
merged 1 commit into from
Jan 14, 2023

Conversation

ExpandingMan
Copy link
Collaborator

Recently we changed XGBoost.jl so that it warns on invalid parameters by default (and fixed logging so that it goes through the Julia logger).

I really should have made sure this omitted most parameters when I overhauled it in the first place, but the way MLJ model objects work isn't exactly conducive to doing that.

This is admittedly a half-assed fix, but it will prevent users from unnecessarily getting bombarded with invalid parameter warnings.

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, thanks. Do you want to update the doc-strings, adding validate_parameters, to the list of hyper-parameters of each model?

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2023

Codecov Report

Merging #30 (a87fa2f) into master (ab061e4) will decrease coverage by 0.43%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   55.11%   54.68%   -0.44%     
==========================================
  Files           1        1              
  Lines         127      128       +1     
==========================================
  Hits           70       70              
- Misses         57       58       +1     
Impacted Files Coverage Δ
src/MLJXGBoostInterface.jl 54.68% <0.00%> (-0.44%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ExpandingMan
Copy link
Collaborator Author

Do you want to update the doc-strings, adding validate_parameters, to the list of hyper-parameters of each model?

Actually, it doesn't seem the parameters are explicitly documented. Actually this interface conforms with the default of validate_parameters in the xgboost documentation whereas XGBoost.jl does not. I could add a blurb to all the doc strings mentioning it but that seems a bit much. Thoughts?

@ablaom
Copy link
Member

ablaom commented Jan 14, 2023

Actually, it doesn't seem the parameters are explicitly documented. Actually this interface conforms with the default > of validate_parameters in the xgboost documentation whereas XGBoost.jl does not.

Ok, right. In that case I don't think anything further is needed here.

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@ExpandingMan ExpandingMan merged commit 4d7e3e0 into JuliaAI:master Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants