disable parameter validation by default #30
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we changed XGBoost.jl so that it warns on invalid parameters by default (and fixed logging so that it goes through the Julia logger).
I really should have made sure this omitted most parameters when I overhauled it in the first place, but the way MLJ model objects work isn't exactly conducive to doing that.
This is admittedly a half-assed fix, but it will prevent users from unnecessarily getting bombarded with invalid parameter warnings.