Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable parameter validation by default #30

Merged
merged 1 commit into from
Jan 14, 2023
Merged

disable parameter validation by default #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "MLJXGBoostInterface"
uuid = "54119dfa-1dab-4055-a167-80440f4f7a91"
authors = ["Anthony D. Blaom <anthony.blaom@gmail.com>"]
version = "0.3.4"
version = "0.3.5"

[deps]
MLJModelInterface = "e80e1ace-859a-464e-9ed9-23947d8ae3ea"
Expand Down
3 changes: 3 additions & 0 deletions src/MLJXGBoostInterface.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,9 @@ function modelexpr(name::Symbol, absname::Symbol, obj::AbstractString, objvalida
nthread::Int = Base.Threads.nthreads()::(_ ≥ 0)
importance_type::String = "gain"
seed::Union{Int,Nothing} = nothing # nothing will use built in default
# this should probably be fixed so that we don't pass invalid parameters,
# but in the meantime, let's just disable checking
validate_parameters::Bool = false
end

end
Expand Down