Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecations with nt.names and kw.data #201

Merged
merged 3 commits into from
Jul 25, 2021
Merged

Fix deprecations with nt.names and kw.data #201

merged 3 commits into from
Jul 25, 2021

Conversation

JeffFessler
Copy link
Contributor

Addresses #200

src/core.jl Outdated Show resolved Hide resolved
JeffFessler and others added 2 commits July 24, 2021 22:15
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jul 24, 2021

Codecov Report

Merging #201 (b13994c) into master (bf961cf) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
- Coverage   89.45%   89.31%   -0.14%     
==========================================
  Files           7        7              
  Lines         673      674       +1     
==========================================
  Hits          602      602              
- Misses         71       72       +1     
Impacted Files Coverage Δ
src/indexing.jl 82.51% <ø> (-0.46%) ⬇️
src/core.jl 87.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf961cf...b13994c. Read the comment docs.

@johnnychen94
Copy link
Member

johnnychen94 commented Jul 25, 2021

Sorry for the delay! I'll go through other PRs later tonight and make a patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants