Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump AxisArrays version (Fixes Julia 1.7) #322

Merged
merged 1 commit into from
Jul 30, 2021

Conversation

rikhuijzer
Copy link
Contributor

@rikhuijzer rikhuijzer commented Jul 28, 2021

AxisArrays works now on Julia 1.7 thanks to JuliaArrays/AxisArrays.jl#201.

@rikhuijzer
Copy link
Contributor Author

rikhuijzer commented Jul 28, 2021

The single failure on nightly x64 (Ubuntu, Windows, MacOS) is caused by a PR from a few days ago (JuliaLang/julia#41619) and will be fixed in JuliaStats/StatsBase.jl#703. The failure on nightly x86 seems like another upstream bug.

@rikhuijzer
Copy link
Contributor Author

The explicit pinning of AxisArrays to 0.4.4 is due to #213. Since AxisArrays 0.4.4 works on Julia 1.0 as well as Julia 1.7, I don't think it is necessary to set AxisArrays = "0.4.2, 0.4.4". But, of course, there are also arguments to use both.

@cpfiffer cpfiffer merged commit 9faac83 into TuringLang:master Jul 30, 2021
@rikhuijzer rikhuijzer deleted the bump-axisarrays branch July 31, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants