Fix reading gzipped file in Julia 1.11 on Windows #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1144 +/- ##
==========================================
+ Coverage 90.22% 90.27% +0.05%
==========================================
Files 9 9
Lines 2312 2314 +2
==========================================
+ Hits 2086 2089 +3
+ Misses 226 225 -1 ☔ View full report in Codecov by Sentry. |
|
@longemen3000 @oscarvdvelde @JakeZw This PR is ready for review now |
quinnj
reviewed
Oct 19, 2024
| if !chunking && Sys.iswindows() && ctx.stringtype !== PosLenString | ||
| finalize(ctx.buf) | ||
| if VERSION ≥ v"1.11" |
quinnj
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1137
On Julia 1.11 the underlying memory needs to be finalized to unmmap the file.
Ref: JuliaLang/julia#54210