-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide formatter for labeling categories in cut
function
#202
Conversation
Thanks, sounds useful. Though I'd just use the |
Ah, and can you add a test? |
updated and improved EDIT: shall I rebase? |
d9a05d7
to
d1a3461
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments.
Co-Authored-By: Milan Bouchet-Valat <nalimilan@club.fr>
16767c8
to
b224dac
Compare
src/extras.jl
Outdated
|
||
# Examples | ||
```jldoctest | ||
julia> using CategoricalArrays |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this actually needed? There's probably a way to avoid it as it takes a lot of space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please clarify what you mean by "this"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean this using
line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks - I dropped it. Let's see what CI says
Co-Authored-By: Milan Bouchet-Valat <nalimilan@club.fr>
ad47e03
to
54e02ce
Compare
28990fc
to
9b7cc87
Compare
src/extras.jl
Outdated
|
||
# Examples | ||
```jldoctest | ||
julia> using CategoricalArrays |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean this using
line.
Co-Authored-By: Milan Bouchet-Valat <nalimilan@club.fr>
10e044a
to
8a0e2e5
Compare
Thanks! |
This is something I find useful. One could even add the group index as an additional argument.
Is this something that is worth adding?
e.g.