-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial #2697
Tutorial #2697
Conversation
docs/src/assets/german_credit.csv
Outdated
@@ -0,0 +1,1001 @@ | |||
,Age,Sex,Job,Housing,Saving accounts,Checking account,Credit amount,Duration,Purpose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why rowid column does not have a name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, yeah. Fixing it. In the kaggle they had mentioned using #.
docs/src/assets/readme.txt
Outdated
@@ -0,0 +1,34 @@ | |||
# Source |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you use markdown then better name it readme.md (this is even better)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, fixing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is enough to do a list of files we provide in assets. And for each file add information about the original source, the source from which we have taken the file and a link to the license we use (like Kaggle - they just give a link to the license)
docs/src/assets/readme1.txt
Outdated
@@ -0,0 +1,487 @@ | |||
# Source |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as per comment above then one file would be enough
docs/src/assets/readme.md
Outdated
@@ -0,0 +1,439 @@ | |||
# Source |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As commented - I would avoid adding this much detail.
Just write something like
# Introduction
In this folder we store the following data sets:
* german_credit.csv
* iris.csv
# German Credit data set
## License:
link
## Source:
both info that the original data is from UCI, and that this data is from Kaggle (as this information is missing)
If you feel uncomfortable with something just leave an empty space and I will fill it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh okay, i had not read your above comment.
|
||
The original data is from [UCI](https://archive.ics.uci.edu/ml/datasets/statlog+(german+credit+data)), and that this data is from [Kaggle](https://www.kaggle.com/uciml/german-credit) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Iris data set | |
## License | |
https://creativecommons.org/publicdomain/zero/1.0/ | |
## Source: | |
https://archive.ics.uci.edu/ml/datasets/Iris | |
Creator: | |
R.A. Fisher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the future you can just clik "Commit suggestion" (or edit it before accepting and then commit)
Here I meant rebasing because I assumed that most likely this PR would have conflicts with other changes you make. Therefore it is better to open it again against latest |
No description provided.