Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial #2697

Closed
wants to merge 5 commits into from
Closed

Tutorial #2697

wants to merge 5 commits into from

Conversation

RohitRathore1
Copy link
Contributor

No description provided.

@bkamins bkamins added the doc label Apr 2, 2021
@bkamins bkamins added this to the 1.x milestone Apr 2, 2021
@@ -0,0 +1,1001 @@
,Age,Sex,Job,Housing,Saving accounts,Checking account,Credit amount,Duration,Purpose
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why rowid column does not have a name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yeah. Fixing it. In the kaggle they had mentioned using #.

@@ -0,0 +1,34 @@
# Source
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you use markdown then better name it readme.md (this is even better)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, fixing it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is enough to do a list of files we provide in assets. And for each file add information about the original source, the source from which we have taken the file and a link to the license we use (like Kaggle - they just give a link to the license)

@@ -0,0 +1,487 @@
# Source
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per comment above then one file would be enough

@@ -0,0 +1,439 @@
# Source
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented - I would avoid adding this much detail.

Just write something like

# Introduction

In this folder we store the following data sets:

* german_credit.csv
* iris.csv

# German Credit data set

## License:
link

## Source:

both info that the original data is from UCI, and that this data is from Kaggle (as this information is missing)

If you feel uncomfortable with something just leave an empty space and I will fill it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh okay, i had not read your above comment.


The original data is from [UCI](https://archive.ics.uci.edu/ml/datasets/statlog+(german+credit+data)), and that this data is from [Kaggle](https://www.kaggle.com/uciml/german-credit)


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Iris data set
## License
https://creativecommons.org/publicdomain/zero/1.0/
## Source:
https://archive.ics.uci.edu/ml/datasets/Iris
Creator:
R.A. Fisher

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the future you can just clik "Commit suggestion" (or edit it before accepting and then commit)

@bkamins
Copy link
Member

bkamins commented Apr 3, 2021

Given you have opened #2700 please make sure to correctly handle rebasing of this PR before submitting it for a review (as I assume in this PR you will add tutorial sections and in #2700 you propose to change the legacy structure of the tutorial).

@bkamins
Copy link
Member

bkamins commented Apr 11, 2021

Here I meant rebasing because I assumed that most likely this PR would have conflicts with other changes you make. Therefore it is better to open it again against latest main. I assume this is what you are planning to do. Right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants