-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
promoted documentation on working with DataFrames #2700
Conversation
OK - we can make this change (though this part of the manual is likely to get replaced soon by the new manual - right?). If we go for it then also the sections on "Replacing data" and "Importing and Exporting Data (I/O)" should be moved to this separate file (as now you have extracted one section in the middle of the manual and applying this change would change the order in which the user would read it). |
|
Because of typo error in file name building was failing. So fixed it |
As commented on Slack - please make sure that before you push a PR to GitHub you are able to build the documentation locally and all looks good. |
yes, I am following this now. |
docs/make.jl
Outdated
@@ -22,6 +22,9 @@ makedocs( | |||
"Introduction" => "index.md", | |||
"User Guide" => Any[ | |||
"Getting Started" => "man/getting_started.md", | |||
"Working with DataFrames" => "man/Working_with_DataFrames.md", | |||
"Replacing Data" => "man/replacing_data.md", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you feel (as a user) it is worth to promote "Replacing Data" to top level here? Or it is better to have it as a section in "Working with DataFrames"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so because when a user will review 'Working with DataFrames' then after completing that section he can directly jump to the 'Replacing Data' section in the series. But both things will be fine(show it as a section in 'working with DataFrames' or promote it to the top level).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would then include "Replacing Data" in "Working with DataFrames"
Thank you! |
It resolves issue #2623 where our aim was to promote documentation on working with DataFrames as the sub-sub section of working with DataFrames was not appearing in the left menu navigation.