Skip to content

Commit

Permalink
Remove istable for a value of type AbstractMatrix (#198)
Browse files Browse the repository at this point in the history
I think - as in other places - we should only define a method for a type, and use a default fallback for the value.

@quinnj Was there some specific reason why in this case a method for a value was introduced?
  • Loading branch information
bkamins authored and quinnj committed Aug 16, 2022
1 parent fa6dfe6 commit ca505ee
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/matrix.jl
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
istable(::AbstractMatrix) = false
istable(::Type{<:AbstractMatrix}) = false

rows(m::T) where {T <: AbstractMatrix} = throw(ArgumentError("a '$T' is not a table; see `?Tables.table` for ways to treat an AbstractVecOrMat as a table"))
Expand Down

0 comments on commit ca505ee

Please sign in to comment.