Remove istable for a value of type AbstractMatrix #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think - as in other places - we should only define a method for a type, and use a default fallback for the value. @quinnj Was there some specific reason why in this case a method for a value was introduced?
|
I don't remember really |
|
Looks like there's a test that needs to be updated |
|
Yes - I will fix it, but first I wanted to check the direction 😄. |
|
We should fix a bug in TrableTraits.jl and not change anything here. But let us wait till queryverse/TableTraits.jl#21 is resolved. |
|
I just came across this PR since I noticed that my implementation of |
|
After @quinnj agrees to the proposal I will update the tests. |
|
@quinnj - after TableTraits.jl fix the tests pass |
|
Thanks! |
|
I just noticed that the PR was made against and merged into master instead of main. That seems incorrect? |
|
Ah, great catch! I'll merge it over to main |
quinnj
pushed a commit
that referenced
this pull request
Aug 16, 2022
I think - as in other places - we should only define a method for a type, and use a default fallback for the value. @quinnj Was there some specific reason why in this case a method for a value was introduced?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think - as in other places - we should only define a method for a type, and use a default fallback for the value.
@quinnj Was there some specific reason why in this case a method for a value was introduced?