dual exponent #605
Merged
dual exponent #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcabbott
approved these changes
Nov 11, 2022
|
The tests passed! I think we are good to merge. |
Merged
mcabbott
pushed a commit
to mcabbott/ForwardDiff.jl
that referenced
this pull request
Dec 3, 2022
* add exponent(::Dual) * revert spacing
mcabbott
added a commit
that referenced
this pull request
Dec 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue came up in FluxML/Zygote.jl#1324 (comment).
The problem is that on Julia 1.6, the GPU was sensing it could hit a code branch where
exponent(::Dual)was being called, and unfortunately,exponent(::Dual)does not exist, so the GPU threw a dynamic call error and gave up. This pull request fixes this.Solving this problem is pretty easy since exponent: Real --> Int function, so you can take a similar path compared to
truncand define the Dual argument to return the primal value, which I did.