-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 0.11 #613
Version 0.11 #613
Conversation
Test failure on 1.8 is a tolerance issue.
|
I think before doing that (also since discussions and decisions might take some time) it would be useful to tag a non-breaking 0.10 release with #605. That is, I think it would be good to revert #481 on the master branch and not only yank the latest release. That would also allow us to include more non-breaking fixes and features in 0.10 that come up before this PR is merged. In general, maybe it would be useful to backport bug fixes for some time to 0.10 once 0.11 is released due to the widespread use of 0.10 (sinilar to what we do in SpecialFunctions where currently bug fixes for version 2 are backported to 1). |
I think better just to make a branch for backports to 0.10, and then cherry pick whatever commits desired onto that. That's ends up with the right graph of changes, right? The branching and tagging can be done before 0.11. Reverting seems (in my experience) to lead to changes rotting quietly somewhere. There was already far too much fighting with tests & re-basing in 481. |
There was already a release-0.3 branch from way back when, presumably for the same purpose. So now there's a new one: https://github.com/JuliaDiff/ForwardDiff.jl/tree/release-0.10 Edit: and #614 moves one change. |
Would love to see #615 (I think it is not breaking though formally changes API, ymmv...). |
#615 looks safe. Something new we could consider for 0.11 is to use "package extensions" rather than directly loading so many other packages. |
Merging since v0.10.34 is now tagged on release-0.10 branch, JuliaRegistries/General#73859 . |
As for the package extensions: IMHO ForwardDiff loading many packages is no problem (compared to other packages). And for at least 1.6 backward compatibility one would have to mimic them via Requires.jl, thus losing compat guarantees for the corresponding packages on those older versions AFAIK. So I think this would introduce brittleness into an otherwise rock stable (from my experience) package with not much additional value. |
It could I think always load them on old versions (as now) rather than using Requires. |
After JuliaRegistries/General#73304 we should probably tag changes as 0.11.
This PR just updates the version number. It drops Julia 1.0 to enable #599 without further surprises.
We may wish to include other things in 0.11:
<=
as in Violating assumptions about Dual comparisons #609isinteger
and friends: Change==
to ignore measure-zero branches #481 (comment)==
to ignore measure-zero branches #481 (comment)