Update from analytics.js to gtag.js #1559
Conversation
|
Ping @IanButterworth and @MichaelHatherly who show up in blame for the Analytics code. See also #1121 |
I believe I added that to help Analytics tie search results to landing page tag i.e. section on a page, to try and highlight areas for improvement in SEO |
|
Should we try to keep the snippet though @IanButterworth? |
|
I don't know how gtag works (this is the first I've heard of it) so try the above, perhaps? |
Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com>
Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com>
src/Writers/HTMLWriter.jl
Outdated
| @@ -891,13 +891,13 @@ end | |||
| analytics_script(tracking_id::AbstractString) = | |||
| isempty(tracking_id) ? Tag(Symbol("#RAW#"))("") : Tag(:script)( | |||
There was a problem hiding this comment.
Tag(:script) tag may be redundant with <script>
There was a problem hiding this comment.
Sorry for the delay. But yes, you're right, this would be redundant. In fact, you'd end up with nested <script> tags, which means that I don't think this would work at all at the moment.
Instead, I'd recommend explicitly constructing both of the <script> tags in Julia. It should be fine if analytics_script returns an array of Tags.
There was a problem hiding this comment.
Is the syntax for constructing tags in Julia documented? (e.g., how do you do <script async src="...">?)
There was a problem hiding this comment.
Yep: https://juliadocs.github.io/Documenter.jl/stable/lib/internals/dom/
Also, heaps of usage examples in HTMLWriter.jl.
|
I took the liberty of fixing this up. Testing it locally, it seems to submit the correct page name, including the fragment -- thanks @mlubin and @IanButterworth for figuring that out! |
|
Thanks @mortenpi! |
Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com> Co-authored-by: Morten Piibeleht <morten.piibeleht@gmail.com>
The current Google Analytics code appears to be deprecated (it was triggering reminder emails for me).
I followed the instructions at https://developers.google.com/analytics/devguides/collection/upgrade/analyticsjs#analyticsjs_2_gtagjs to update the script.
Note that I don't understand the purpose of
{'page': location.pathname + location.search + location.hash}and if we should do something similar in the new script. (Despite working at Google, I have no special knowledge of the Analytics API.)