Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add analytics to docs #116

Merged
merged 3 commits into from
Apr 22, 2021
Merged

add analytics to docs #116

merged 3 commits into from
Apr 22, 2021

Conversation

OriolAbril
Copy link
Member

Adds google analytics to the documentation page. We'll then gather some data now and after season of
docs we'll be able to see if there is an increase in traffic and retention of visitors.

Copy link
Member

@sethaxen sethaxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once the formatter workflow passes

docs/make.jl Outdated Show resolved Hide resolved
Fix formatting

Co-authored-by: Seth Axen <seth.axen@gmail.com>
@OriolAbril
Copy link
Member Author

OriolAbril commented Apr 17, 2021

I added the tracking code to the python website and it doesn't seem to be working, not sure if I generated the wrong codes or there is a bug in the sphinx theme. Somehow we have superfancy analytics for aeviz and everything is different from my personal account and the pymc3 one

Let's see how it goes here

@OriolAbril
Copy link
Member Author

Looks like we'll have the same issue here. I'll try to send a PR to update https://github.com/JuliaDocs/Documenter.jl/blob/master/src/Writers/HTMLWriter.jl#L891 and work with either G- or UA- codes.

@OriolAbril
Copy link
Member Author

It looks like there is an error with the netcdf roundtrip and with summarystats. Are these tests on master or latest version?

@sethaxen
Copy link
Member

Looks like we'll have the same issue here. I'll try to send a PR to update https://github.com/JuliaDocs/Documenter.jl/blob/master/src/Writers/HTMLWriter.jl#L891 and work with either G- or UA- codes.

Is JuliaDocs/Documenter.jl#1559 relevant?

It looks like there is an error with the netcdf roundtrip and with summarystats. Are these tests on master or latest version?

These are in the Futures workflow, which is allowed to fail and just lets us know of future breaking changes (from unreleased Jula or ArviZ versions). They shouldn't hold up this PR. The netcdf one I haven't seen before and will look into.

@sethaxen
Copy link
Member

The docs build is timing out after 6 hours though. In the past, this has happened due to some mutual incompatibility of some dependency(s) of Soss, Turing, and Documenter, and I've never been able to diagnose it; it usually gets resolved when some version is released.

Pretty much the only way around this besides waiting for it to be fixed elsewhere is probably to split the Quickstart into different pages for Soss, Turing, and CmdStan and execute the examples in their own environment.

@OriolAbril
Copy link
Member Author

Is JuliaDocs/Documenter.jl#1559 relevant?

Indeed, this will fix the issue :). Feel free to merge whenever is best for you, analytics won't work until that PR is merged but in the meantime, this should not break docs nor have any noticeable effect in them, it's only a cryptic javascript error that you can only see if you open the web developer tools.

@sethaxen sethaxen closed this Apr 22, 2021
@sethaxen sethaxen reopened this Apr 22, 2021
@sethaxen sethaxen closed this Apr 22, 2021
@sethaxen sethaxen reopened this Apr 22, 2021
@sethaxen sethaxen mentioned this pull request Apr 22, 2021
@sethaxen sethaxen merged commit 0947e42 into arviz-devs:main Apr 22, 2021
@OriolAbril OriolAbril deleted the analytics branch April 22, 2021 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants